Make qemu-img create options generic
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | Create qemu-option.hMakefile qemu-option.c qemu-option.h +2 more | +418 | 0 replies | |
| 2/4 | Convert all block drivers to new bdrv_createblock.c block.h block/ +9 more | +214 | 0 replies | |
| 3/4 | Convert qemu-img create to new bdrv_createqemu-img.c | +87 | 0 replies | |
| 4/4 | Convert qemu-img convert to new bdrv_createqemu-img.c | +65 | 2 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [Qemu-devel] [PATCH 0/4] Make qemu-img create options generic
Currently, qemu-img and the bdrv_create() interface need to carry parameters for every single option that is used by at least one file format. We already have a few of such format specific options (encryption for qcow2, version 6 header for VMDK, backing file for some formats) and there are more to come (like qcow cluster size).
This patch series changes this into a more generic approach: All block drivers contain a data structure which describes all options this driver recognizes. qemu-img can use this structure then instead of hard-coding every single option. An -o option is introduced for these parameteres, the format is the usual comma separated name=value style like in -drive.
Kevin Wolf (4):
Create qemu-option.h
Convert all block drivers to new bdrv_create
Convert qemu-img create to new bdrv_create
Convert qemu-img convert to new bdrv_create
Makefile | 2 +- block.c | 44 +++++-- block.h | 6 +- block/cow.c | 26 +++- block/qcow.c | 28 ++++- block/qcow2.c | 36 +++++- block/raw-posix.c | 37 ++++-- block/raw-win32.c | 20 +++- block/vmdk.c | 28 ++++- block/vpc.c | 21 +++- block/vvfat.c | 4 +- block_int.h | 17 ++- qemu-img.c | 188 ++++++++++++++++++++--------- qemu-option.c | 349 +++++++++++++++++++++++++++++++++++++++++++++++++++++ qemu-option.h | 67 ++++++++++ sysemu.h | 2 - vl.c | 38 +------ 17 files changed, 762 insertions(+), 151 deletions(-) create mode 100644 qemu-option.c create mode 100644 qemu-option.h