Skip to content

tracing/core: various fixes

Frederic Weisbecker lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5tracing: add trace_event_read_lock()kernel/trace/trace.c kernel/trace/trace_output.c kernel/trace/trace_output.h+28 -70 replies
2/5tracing/events: change the type of __str_loc_item to unsigned shortinclude/trace/ftrace.h+1 -10 replies
3/5kmemtrace: fix kernel parameter documentationDocumentation/kernel-parameters.txt+0 -100 replies
4/5ftrace: Add task_comm support for trace_eventkernel/trace/Kconfig kernel/trace/trace_events.c+13 -20 replies
5/5ftrace: clean up of using ftrace_event_enable_disable()kernel/trace/trace_events.c+14 -300 replies

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchSteven Rostedt
1/5A-b
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] tracing/core: various fixes

Hi Ingo, Steven,

I've gathered various tracing fixes that were posted recently.

Note: the commit b11c53e12f94a46b50bccc7a1a953d7ca1d54a31
(ftrace: Add task_comm support for trace_event)
looks good to me. This v3 solves the two following unhandled dependencies in v1:

ENABLE_EVENT_TRACING -> CONTEXT_SWITCH_TRACER
EVENT_TRACING -> CONTEXT_SWITCH_TRACER

The latter is tricky because CONTEXT_SWITCH_TRACER depends on CONFIG_FTRACE (the tracers menu) from which EVENT_TRACING is excluded. A build error can then occur if something selects CONFIG_TRACING elsewhere.

The fix written by Zhaolei follows the {ENABLE_}EVENT_TRACING
view: we now have CONTEXT_SWITCH_TRACER and ENABLE_CONTEXT_SWITCH_TRACER.

The former is used by EVENT_TRACING to record cmdlines. The latter selects CONTEXT_SWITCH_TRACER plus CONFIG_TRACING. To sum up, ENABLE_CONTEXT_SWITCH_TRACER acts only as a "relay".

It looks good to me, tell me and Zhaolei if you have doubts about it.

Thanks.

The following changes since commit 5537937696c55530447c20aa27daccb8d0d29b33:
Ming Lei (1):
ftrace: fix check for return value of register_module_notifier in event_trace_init

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing.git
tracing/core

Lai Jiangshan (1):
tracing: add trace_event_read_lock()

Li Zefan (1):
tracing/events: change the type of __str_loc_item to unsigned short

Pekka Enberg (1):
kmemtrace: fix kernel parameter documentation

Zhaolei (2):
ftrace: Add task_comm support for trace_event
ftrace: clean up of using ftrace_event_enable_disable()

 Documentation/kernel-parameters.txt |   10 --------
 include/trace/ftrace.h              |    2 +-
 kernel/trace/Kconfig                |    9 +++++-
 kernel/trace/trace.c                |    8 ++++++
 kernel/trace/trace_events.c         |   42 +++++++++++++---------------------
 kernel/trace/trace_output.c         |   25 +++++++++++++++-----
 kernel/trace/trace_output.h         |    2 +
 7 files changed, 52 insertions(+), 46 deletions(-)