Skip to content

nfs-utils: add IPv6 support for rpc.nfsd (try #2)

Jeff Layton linux-nfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6nfs-utils: don't link libexport.a and libmisc.a to nfsdutils/nfsd/Makefile.am+1 -30 replies
2/6nfs-utils: break up nfssvc.c into more individually callable functionssupport/include/nfslib.h support/nfs/nfssvc.c utils/nfsd/nfsd.c+62 -360 replies
3/6nfs-utils: set IPV6_V6ONLY on nfssvc IPv6 socketssupport/nfs/nfssvc.c+18 -20 replies
4/6nfs-utils: add IPv6 support to nfsdutils/nfsd/nfsd.c+120 -314 replies
5/6nfs-utils: limit protocols and families used by nfsd to those listed in /etc/netconfigsupport/include/nfslib.h support/nfs/nfssvc.c utils/nfsd/nfsd.c+94 -100 replies
6/6nfs-utils: add -4 and -6 options to nfsd manpageutils/nfsd/nfsd.man+10 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] nfs-utils: add IPv6 support for rpc.nfsd (try #2)

This is the second attempt to add support IPv6 to rpc.nfsd. The main changes since the last patchset are:

1) the addition of a patch that makes nfsd look at /etc/netconfig when tirpc is enabled, and to disable any family/protocol combinations that don't have visible netid's.

2) stop linking in some unneeded .a libs.

3) some minor bugfixes

4) update to the nfsd manpage for new options

I think the set is bisectable, but have only really tested the final result. I've also tested the final result when built with tirpc enabled and disabled, and ipv6 enabled and disabled.

I haven't seen any regressions when testing on recent mainline kernels and The only real difference that anyone may notice is that when IPv6 support is built in, and the kernel doesn't support IPv6, nfsd logs this message a couple of times when starting nfsd:

nfssvc: writing fds to kernel failed: errno 97 (Address family not supported by protocol)

Most of the testing I've done has been by watching the program under strace. Since most of the kernel work for IPv6 support hasn't made it to mainline, it's a little difficult to do much testing of this beyond that.

Jeff Layton (6):
nfs-utils: don't link libexport.a and libmisc.a to nfsd
nfs-utils: break up nfssvc.c into more individually callable
functions
nfs-utils: set IPV6_V6ONLY on nfssvc IPv6 sockets
nfs-utils: add IPv6 support to nfsd
nfs-utils: limit protocols and families used by nfsd to those listed
in /etc/netconfig
nfs-utils: add -4 and -6 options to nfsd manpage

 support/include/nfslib.h |    8 ++-
 support/nfs/nfssvc.c     |  164 +++++++++++++++++++++++++++++++++----------
 utils/nfsd/Makefile.am   |    4 +-
 utils/nfsd/nfsd.c        |  175 ++++++++++++++++++++++++++++++++++++++--------
 utils/nfsd/nfsd.man      |   10 +++
 5 files changed, 292 insertions(+), 69 deletions(-)