Skip to content

nfs-utils: add IPv6 support for rpc.nfsd (try #3)

Jeff Layton linux-nfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5nfs-utils: don't link libexport.a and libmisc.a to nfsdutils/nfsd/Makefile.am+1 -30 replies
2/5nfs-utils: break up nfssvc.c into more individually callable functionssupport/include/nfslib.h support/nfs/nfssvc.c utils/nfsd/nfsd.c+88 -450 replies
3/5nfs-utils: set IPV6_V6ONLY on nfssvc IPv6 socketssupport/nfs/nfssvc.c+26 -50 replies
4/5nfs-utils: add IPv6 support to nfsdutils/nfsd/nfsd.c+125 -332 replies
5/5nfs-utils: limit protocols and families used by nfsd to those listed in /etc/netconfigsupport/include/nfslib.h support/nfs/nfssvc.c utils/nfsd/nfsd.c+94 -93 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] nfs-utils: add IPv6 support for rpc.nfsd (try #3)

This is the third attempt to add support IPv6 to rpc.nfsd. The main changes since the last patchset are:

1) removal of the -4 and -6 options. The preferred way to disable address families for now will be to configure /etc/netconfig. It's probably better not to add new command line options until there is a clear need for them. Since I'm not adding new options, I've dropped the manpage patch too. We may still want a manpage update eventually to discuss how one should disable address families for nfsd.

2) Fixed the error handling when ipv6.ko is blacklisted. The earlier patchset would cause the program to error out when it couldn't create a socket for an address family. Now, as long as the program succeeds in creating sockets for at least one address family it will declare success. It will however, log an error that it was unable to create the socket for the other.

I think the set is bisectable, but have only really tested the final result. I've also tested the final result when built with tirpc enabled and disabled, and ipv6 enabled and disabled. I've also tested this with a rpc.nfsd built for IPv6 on a host that has ipv6.ko blacklisted.

Most of the testing I've done has been by watching the program under strace. Since most of the kernel work for IPv6 support hasn't made it to mainline, it's a little difficult to do much testing of this beyond that.

Jeff Layton (5):
nfs-utils: don't link libexport.a and libmisc.a to nfsd
nfs-utils: break up nfssvc.c into more individually callable
functions
nfs-utils: set IPV6_V6ONLY on nfssvc IPv6 sockets
nfs-utils: add IPv6 support to nfsd
nfs-utils: limit protocols and families used by nfsd to those listed
in /etc/netconfig

 support/include/nfslib.h |    8 ++-
 support/nfs/nfssvc.c     |  201 +++++++++++++++++++++++++++++++++++----------
 utils/nfsd/Makefile.am   |    4 +-
 utils/nfsd/nfsd.c        |  180 ++++++++++++++++++++++++++++++++++-------
 4 files changed, 316 insertions(+), 77 deletions(-)