Skip to content

Patches for dsbr100 radio

Alexey Klimov linux-media 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4dsbr100: remove radio->users counterlinux/drivers/media/radio/dsbr100.c+0 -80 replies
2/4dsbr100: remove usb_dsbr100_open/close callslinux/drivers/media/radio/dsbr100.c+0 -480 replies
3/4dsbr100: no need to pass curfreq value to dsbr100_setfreq()linux/drivers/media/radio/dsbr100.c+3 -30 replies
4/4dsbr100: change radio->muted to radio->status, update suspend/resumelinux/drivers/media/radio/dsbr100.c+35 -120 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [patch 0/4] Patches for dsbr100 radio

There was discussion on maillist about lock/unlock_kernel, about open/close functions and about radio->users counter. So, there are patches arised from that discussion.

There is suspend/resume procedure fix in patch 4/4.

Here is description of patches:

[1/4] dsbr100: remove radio->users counter
Patch removes radio->users counter because it is not in use.

[2/4] dsbr100: remove usb_dsbr100_open/close calls
Patch removes usb_dsbr100_open and usb_dsbr100_close calls.
1. No need to start, set frequency, adjust parameters in open call.
2. This patch tackles issue with lock/unlock_kernel() in open call.
3. With this patch feature "Mute on exit?" in gnomeradio works.

[3/4] dsbr100: no need to pass curfreq value to dsbr100_setfreq() Small cleanup of dsbr100_setfreq(). No need to pass radio->curfreq value to this function.

[4/4] dsbr100: change radio->muted to radio->status, update suspend/resume
Patch renames radio->muted to radio->status, add defines for that variable, and fixes suspend/resume procedure. Radio->status set to STOPPED in usb_dsbr100_probe because of removing open call. Also, patch increases driver version.

Tested on i686 and x86_64 machines with gnomeradio, mplayer and kradio under 2.6.30-rc7 kernel.

Signature · 1 line
Best regards, Klimov Alexey