Skip to content

updates for oprofile

Robert Richter lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest23 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/23Revert "oprofile: discover counters for op ppro too"arch/x86/oprofile/op_model_ppro.c arch/x86/oprofile/op_x86_model.h+4 -60 replies
2/23x86/oprofile: moving arch_perfmon counter setup to op_x86_model_spec.initarch/x86/oprofile/nmi_int.c arch/x86/oprofile/op_model_ppro.c arch/x86/oprofile/op_x86_model.h+17 -151 reply
3/23x86/oprofile: minor style changes in struct op_x86_model_specarch/x86/oprofile/op_x86_model.h+11 -110 replies
4/23oprofile: remove irq_flags in struct op_entryinclude/linux/oprofile.h+0 -10 replies
5/23oprofile: remove obselete include headersdrivers/oprofile/cpu_buffer.c+0 -10 replies
6/23x86/oprofile: remove #ifdefs in ibs functionsarch/x86/oprofile/op_model_amd.c+46 -340 replies
7/23x86/oprofile: simplify AMD cpu init codearch/x86/oprofile/nmi_int.c+7 -80 replies
8/23x86/oprofile: move common macros to op_x86_model.harch/x86/oprofile/op_model_amd.c arch/x86/oprofile/op_model_p4.c arch/x86/oprofile/op_model_ppro.c +1 more+9 -180 replies
9/23x86/oprofile: remove MSR macros for AMD cpusarch/x86/oprofile/op_model_amd.c+12 -170 replies
10/23x86/oprofile: remove MSR macros for ppro cpusarch/x86/oprofile/op_model_ppro.c+8 -110 replies
11/23x86/oprofile: remove MSR macros for p4 cpusarch/x86/oprofile/op_model_p4.c+19 -200 replies
12/23x86/oprofile: fix and cleanup CTRL_SET_* macrosarch/x86/oprofile/op_model_ppro.c arch/x86/oprofile/op_x86_model.h+10 -90 replies
13/23x86/oprofile: remove unused macros for AMD virtualization profilingarch/x86/oprofile/op_model_amd.c+0 -50 replies
14/23x86/oprofile: pass the model to setup_ctrs() functionsarch/x86/oprofile/nmi_int.c arch/x86/oprofile/op_model_amd.c arch/x86/oprofile/op_model_p4.c +2 more+9 -50 replies
15/23x86/oprofile: replace macros to calculate control registerarch/x86/oprofile/nmi_int.c arch/x86/oprofile/op_model_amd.c arch/x86/oprofile/op_model_ppro.c +1 more+60 -450 replies
16/23x86/oprofile: replace CTR_OVERFLOWED macrosarch/x86/oprofile/op_model_amd.c arch/x86/oprofile/op_model_p4.c arch/x86/oprofile/op_model_ppro.c+15 -170 replies
17/23x86/oprofile: replace CTRL_SET_*ACTIVE macrosarch/x86/oprofile/op_model_amd.c arch/x86/oprofile/op_model_ppro.c arch/x86/oprofile/op_x86_model.h+16 -180 replies
18/23x86/oprofile: replace CTR*_IS_RESERVED macrosarch/x86/oprofile/op_model_amd.c arch/x86/oprofile/op_model_p4.c arch/x86/oprofile/op_model_ppro.c +1 more+15 -180 replies
19/23x86/oprofile: use 64 bit wrmsr functionsarch/x86/oprofile/op_model_amd.c arch/x86/oprofile/op_model_p4.c+10 -92 replies
20/23x86/oprofile: use 64 bit values to save MSR statesarch/x86/oprofile/nmi_int.c arch/x86/oprofile/op_x86_model.h+10 -270 replies
21/23x86/oprofile: remove some local variables in MSR save/restore functionsarch/x86/oprofile/nmi_int.c+4 -80 replies
22/23x86/oprofile: use 64 bit values in IBS functionsarch/x86/oprofile/op_model_amd.c+61 -700 replies
23/23x86/oprofile: introduce oprofile_add_data64()arch/x86/oprofile/op_model_amd.c drivers/oprofile/cpu_buffer.c include/linux/oprofile.h+25 -180 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/23] updates for oprofile

These patches are updates for oprofile, mainly for x86. Most patches for x86 replace many macro definitions by function calls and implement internal 64 bit usage for MSR access. The code is now better readable and maintainable. Future changes can be made easier.

Also, struct op_x86_model_spec has been extended to better describe the x86 model. This patch series introduces common functions that can be used by all x86 models. It is a first step to merge similar model specific code and to get a common code base for all models.

Another change is the rework of arch_perfmon init code. There was model specific code in nmi_int.c. This code is moved to op_model_ppro.c by using the init function pointer in struct op_x86_model_spec.

There are no functional changes in this patch set, it only contains cleanups and reworks.

The following changes since commit 0886751c5d8b19fcee2e65d34ae21c9111e652a9:
Robert Richter (1):
Merge commit 'v2.6.30' into oprofile/master

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git master

-Robert

-----------

Robert Richter (23):
Revert "oprofile: discover counters for op ppro too" x86/oprofile: moving arch_perfmon counter setup to op_x86_model_spec.init x86/oprofile: minor style changes in struct op_x86_model_spec
oprofile: remove irq_flags in struct op_entry
oprofile: remove obselete include headers
x86/oprofile: remove #ifdefs in ibs functions
x86/oprofile: simplify AMD cpu init code
x86/oprofile: move common macros to op_x86_model.h x86/oprofile: remove MSR macros for AMD cpus
x86/oprofile: remove MSR macros for ppro cpus
x86/oprofile: remove MSR macros for p4 cpus
x86/oprofile: fix and cleanup CTRL_SET_* macros x86/oprofile: remove unused macros for AMD virtualization profiling x86/oprofile: pass the model to setup_ctrs() functions x86/oprofile: replace macros to calculate control register x86/oprofile: replace CTR_OVERFLOWED macros
x86/oprofile: replace CTRL_SET_*ACTIVE macros
x86/oprofile: replace CTR*_IS_RESERVED macros
x86/oprofile: use 64 bit wrmsr functions
x86/oprofile: use 64 bit values to save MSR states x86/oprofile: remove some local variables in MSR save/restore functions x86/oprofile: use 64 bit values in IBS functions x86/oprofile: introduce oprofile_add_data64()

 arch/x86/oprofile/nmi_int.c       |   98 +++++++-------
 arch/x86/oprofile/op_model_amd.c  |  267 ++++++++++++++++---------------------
 arch/x86/oprofile/op_model_p4.c   |   60 ++++-----
 arch/x86/oprofile/op_model_ppro.c |   95 ++++++--------
 arch/x86/oprofile/op_x86_model.h  |   47 ++++---
 drivers/oprofile/cpu_buffer.c     |   16 ++-
 include/linux/oprofile.h          |    2 +-
 7 files changed, 281 insertions(+), 304 deletions(-)