tpm_tis: various cleanups, and support for Intel iTPM
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest6 patches 12 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | tpm_tis: various cleanupsdrivers/ | +10 | 1 reply | |
| 2/6 | tpm_tis: add MODULE_DEVICE_TABLE to enable autoloaddrivers/ | +1 | 1 reply | |
| 3/6 | tpm_tis: set timeouts before calling request_localitydrivers/ | +6 | 0 replies | |
| 4/6 | tpm_tis: print complete vendor informationdrivers/ | +1 | 1 reply | |
| 5/6 | tpm_tis: convert from pnp_driver to acpi_driverdrivers/ drivers/ | +121 | 21 replies | |
| 6/6 | tpm_tis: add workarounds for iTPMdrivers/ | +13 | 4 replies |
Reviews trailers per patch
4 of 6 patches have a Reviewed-by or Acked-by.
| Patch | Rajiv Andrade | Seiji Munetoh | Eric Paris |
|---|---|---|---|
| 1/6 | A-b | ||
| 2/6 | A-b | ||
| 3/6 | |||
| 4/6 | A-b | ||
| 5/6 | T-b | A-b | |
| 6/6 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH 0/6] tpm_tis: various cleanups, and support for Intel iTPM
Several patches to improve drivers/char/tpm/tpm_tis.c:
- autoload tpm_tis.ko based on acpi / pnp
- fix driver/hardware bugs observed on iTPM
- improve module probing printks
- add workaround code for iTPM
With these patches, the T500's iTPM probes ok and has reasonable contents in /sys/kernel/security/tpm0/ascii_bios_measurements:
% dmesg|grep tpm
[ 8.599680] tpm_tis INTC0102:00: found 0xfed40000(0x5000) [ 8.599769] tpm_tis INTC0102:00: no IRQ found in _CRS, polling mode [ 8.608607] tpm_tis INTC0102:00: 1.2 TPM (8086:1020 rev 6) [ 8.608665] tpm_tis INTC0102:00: Intel iTPM workaround enabled
% sudo head -3 /sys/kernel/security/tpm0/ascii_bios_measurements
0 d6184a2d2e3a8bfae13a1ebb37d62e222bfab57d 08 [S-CRTM Version] 1 0f18524a0ed83806de3bab13c05e2dcc7a8e9c09 09 [CPU Microcode] 0 d9f7d65755c884f6c25680d577f348523006eed3 01 [POST CODE]
Also, I've tested that the driver still works on Dell E4300.
I'm not sure that switching to ACPI probing is either necessary or a good idea, but I wasn't able to get the pnp_driver system to load the driver on the Lenovo.
drivers/char/tpm/Kconfig | 2 +- drivers/char/tpm/tpm_tis.c | 202 +++++++++++++++++------ 2 files changed, 150 insertions(+), 54 deletions(-)
-andy