Skip to content

xen: msi support for Xen dom0

Qing He xen-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3xen: make pci notifier work with booting devicesdrivers/xen/pci.c+1 -10 replies
2/3xen: add msi support for dom0arch/x86/include/asm/xen/pci.h arch/x86/kernel/apic/io_apic.c arch/x86/xen/pci.c +2 more+172 -20 replies
3/3xen: re-enable msiarch/x86/xen/apic.c drivers/pci/pci.h include/linux/pci.h+2 -90 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] xen: msi support for Xen dom0

This patch set adds support for msi in Xen dom0. It's based on the pci notifier patches of Weidong Han (on rebase/pci branch) and contains the following 3 patches.

[PATCH 1/3] xen: make pci notifier work with booting devices [PATCH 2/3] xen: add msi support for dom0
[PATCH 3/3] xen: re-enable msi (effectively revert bf89bc29)

One of the problem left is how to save/restore MSI across S3. Since pci_restore_msi_state() now doesn't have any arch specific hook, the code in arch/x86/ won't get a chance to run during S3 wakeup, so write_msi_msg() is called instead of xen specific functions. One of the possible solutions (and which I prefer) is to add something like arch_pci_restore_msi, but that involves slightly changing drivers/pci/msi.c, which probably needs more thinking and discussion.

An alternative is to trap and emulate any access to pci configuration space. In that case, nothing in dom0 needs changing, and write_msi_msg can be reused, but considerable logic may need to change in Xen hypervisor.

Thanks,
Qing