Skip to content

snapshot-merge target

Mike Snitzer dm-devel 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest13 patches 4 repliesIn review
  2. v413 patches 2 repliesSuperseded
  3. v312 patches 7 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v217 patches5 repliesSuperseded
v112 patches2 repliesSuperseded

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13dm snapshot: rework writing to snapshot origindrivers/md/dm-snap.c+57 -1080 replies
2/13dm exception store: add snapshot-merge specific methodsdrivers/md/dm-exception-store.h drivers/md/dm-snap-persistent.c+86 -00 replies
3/13dm exception store: snapshot-merge usage accountingdrivers/md/dm-snap-persistent.c+18 -10 replies
3/13dm exception store: snapshot-merge usage accountingdrivers/md/dm-snap-persistent.c+7 -34 replies
4/13dm snapshot: add snapshot-merge targetDocumentation/device-mapper/snapshot.txt drivers/md/dm-snap.c+91 -170 replies
5/13dm snapshot: merge target should not allocate new exceptionsdrivers/md/dm-snap.c+60 -20 replies
6/13dm snapshot: do not allow more than one merging snapshot.drivers/md/dm-snap.c+35 -10 replies
7/13dm snapshot: the merge proceduredrivers/md/dm-exception-store.h drivers/md/dm-snap.c+190 -60 replies
8/13dm snapshot: queue writes to an area that is actively being mergeddrivers/md/dm-snap.c+94 -380 replies
9/13dm snapshot: do not merge a chunk until active writes to it finishdrivers/md/dm-snap.c+6 -10 replies
10/13dm snapshot: make exceptions in other snapshots when mergingdrivers/md/dm-snap.c+31 -10 replies
11/13dm snapshot: redirect accesses to origin if merging snap invalidateddrivers/md/dm-snap.c+4 -50 replies
12/13dm snapshot: merge a linear region of chunks using one large IOdrivers/md/dm-snap.c+23 -120 replies
13/13dm snapshot: report merge failure in statusdrivers/md/dm-snap.c+13 -10 replies
13/13dm snapshot: report merge failure in statusdrivers/md/dm-snap.c+12 -10 replies

Reviews trailers per patch

5 of 15 patches have a Reviewed-by or Acked-by.

PatchMike SnitzerMikulas Patocka
1/13
2/13R-b
3/13A-b
3/13A-b
4/13
5/13
6/13
7/13
8/13
9/13R-b
10/13
11/13R-b
12/13
13/13
13/13

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 00/13] snapshot-merge target

The snapshot-merge target allows a snapshot to be merged back into the snapshot's origin device.

One expected use of snapshot merging is the rollback of a root filesystem after system upgrades (e.g.: yum update). snapshot-merge enables "system rollback" support for any filesystem that is using the associated DM/LVM devices.

For LVM2 support please see:
http://people.redhat.com/msnitzer/patches/snapshot-merge/lvm2/LVM2-2.02.57/

v5 of this snapshot-merge series has the following changes:

* Updated to stack on agk's latest 'editing' quilt tree
* Added more content to Documentation/device-mapper/snapshot.txt
* Added comment block above snapshot_merge_map()
* Improved DMERR messages in merge_callback()
* Changed is_merge() macro to compare ti->type->name with a static string constant rather than checking ->map
* 'merging' flag is no longer cleared in persistent_prepare_exception
* Initialized 'merging_snap' to NULL in __find_merging_snapshot
* Removed one level of nesting in __validate_exception_handover
* Added 'merge_failed' flag to dm_snapshot structure and report merge failure accordingly in snapshot_status()

Mike Snitzer (3):
dm exception store: snapshot-merge usage accounting dm snapshot: merge a linear region of chunks using one large IO dm snapshot: report merge failure in status

Mikulas Patocka (10):
dm snapshot: rework writing to snapshot origin
dm exception store: add snapshot-merge specific methods dm snapshot: add snapshot-merge target
dm snapshot: merge target should not allocate new exceptions dm snapshot: do not allow more than one merging snapshot. dm snapshot: the merge procedure
dm snapshot: queue writes to an area that is actively being merged dm snapshot: do not merge a chunk until active writes to it finish dm snapshot: make exceptions in other snapshots when merging dm snapshot: redirect accesses to origin if merging snap invalidated

 Documentation/device-mapper/snapshot.txt |   60 +++-
 drivers/md/dm-exception-store.h          |   27 ++
 drivers/md/dm-snap-persistent.c          |   89 +++++-
 drivers/md/dm-snap.c                     |  603 +++++++++++++++++++++++-------
 4 files changed, 647 insertions(+), 132 deletions(-)