Skip to content

: USB: ftdi_sio: fix regression in 2.6.31 and clean up

Johan Hovold lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4USB: ftdi_sio: remove tty->low_latencydrivers/usb/serial/ftdi_sio.c+0 -40 replies
2/4USB: ftdi_sio: remove unused rx_byte counterdrivers/usb/serial/ftdi_sio.c+0 -130 replies
3/4USB: ftdi_sio: clean up read completion handlerdrivers/usb/serial/ftdi_sio.c+1 -270 replies
4/4USB: ftdi_sio: re-implement read processingdrivers/usb/serial/ftdi_sio.c+131 -2520 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4]: USB: ftdi_sio: fix regression in 2.6.31 and clean up

Hi,

These patches clean up the ftdi_sio driver and fixes

1) a long outstanding bug manifesting itself as

 	BUG: sleeping function called from invalid context at kernel/mutex.c:280

2) a couple of regressions in 2.6.31 (stalled reads and unthrottle race) due to changes in the tty layer.

Please have a look at it so we can get something back-ported to stable as the ftdi_sio driver is currently completly broken and unusable due to the stalled reads.

Note that the patches do not add suspend/resume support to the driver (but the clean up should make it easier to implement).

Thanks to Alan Cox, Oliver Neukum, and Alan Stern for all comments and suggestions so far.

Thanks,
Johan

drivers/usb/serial/ftdi_sio.c | 422 +++++++++++++----------------------------

 1 files changed, 129 insertions(+), 293 deletions(-)