Skip to content

Per route TCP options support kill switches

Gilad Ben-Yossef netdev 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest7 patches 3 repliesIn review
  2. v37 patches 4 repliesSuperseded
  3. v28 patches 25 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v1 RFC1 patch0 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7Only parse time stamp TCP option in time wait socknet/ipv4/tcp_minisocks.c+2 -20 replies
2/7Allow tcp_parse_options to consult dst entryinclude/net/tcp.h net/ipv4/syncookies.c net/ipv4/tcp_input.c +4 more+56 -420 replies
3/7Add dst_feature to query route entry featuresinclude/net/dst.h+7 -10 replies
4/7Add the no SACK route option featureinclude/linux/rtnetlink.h net/ipv4/tcp_input.c net/ipv4/tcp_output.c+6 -30 replies
5/7Allow disabling TCP timestamp options per routeinclude/linux/rtnetlink.h net/ipv4/tcp_input.c net/ipv4/tcp_output.c+9 -40 replies
6/7Allow to turn off TCP window scale opt per routeinclude/linux/rtnetlink.h net/ipv4/tcp_input.c net/ipv4/tcp_output.c+7 -30 replies
7/7Allow disabling of DSACK TCP option per routeinclude/linux/rtnetlink.h net/ipv4/tcp_input.c+7 -20 replies

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by.

PatchOri FinkelmanYony Amit
1/7
2/7Sigend-off-by Sigend-off-by
3/7Sigend-off-by Sigend-off-by
4/7Sigend-off-by Sigend-off-by
5/7Sigend-off-by Sigend-off-by
6/7Sigend-off-by Sigend-off-by
7/7Sigend-off-by Sigend-off-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCHv4 0/7] Per route TCP options support kill switches

Allow selectively turning off support for specific TCP options on a per route basis.

One normally want to disable SACK, DSACK, time stamp or window scale if one got a piece of broken networking equipment somewhere as a stop gap until you can bring a big enough hammer to deal with the broken network equipment. It doesn't make sense to "punish" the entire connections going through the machine to destinations not related to the broken equipment.

This is doubly true when one is dealing with network containers used to isolate several virtual domains.

Per route options implemented in free bits in the features route entry property, which in some cases were reserved by name for these options, so this does not inflate any structure.

Global sysctls for these options are still preserved and retain the exact original meaning (e.g. you have to have both the global sysctl turned on and not turn off the TCP option parsing in the specific route to have it proccessed).

It is not possible to turn off globally an option but turn it on per route, so as to not subtly change the meaning of current establish sysctls (and this is a rare need anyway).

Tested on x86 using Qemu/KVM.

Working but crude matching patch to iproute2 sent earlier to the list.

Patchset based on original work by Ori Finkelman and Yony Amit from ComSleep Ltd.

The author wishes to thank Eric Dumazaet, William Allen Simpson, Bill Fink and Ilpo Jarvinen for their feedback.

Gilad Ben-Yossef (7):
Only parse time stamp TCP option in time wait sock Allow tcp_parse_options to consult dst entry Add dst_feature to query route entry features Add the no SACK route option feature
Allow disabling TCP timestamp options per route Allow to turn off TCP window scale opt per route Allow disabling of DSACK TCP option per route

 include/linux/rtnetlink.h |    6 ++++--
 include/net/dst.h         |    8 +++++++-
 include/net/tcp.h         |    3 ++-
 net/ipv4/syncookies.c     |   27 ++++++++++++++-------------
 net/ipv4/tcp_input.c      |   26 ++++++++++++++++++--------
 net/ipv4/tcp_ipv4.c       |   21 ++++++++++++---------
 net/ipv4/tcp_minisocks.c  |    9 ++++++---
 net/ipv4/tcp_output.c     |   18 +++++++++++++-----
 net/ipv6/syncookies.c     |   28 +++++++++++++++-------------
 net/ipv6/tcp_ipv6.c       |    3 ++-
 10 files changed, 93 insertions(+), 56 deletions(-)