Skip to content

sfc: Cleanup and preparation for new hardware

Ben Hutchings netdev 1 version In review

Get series with b4
b4 am 1256322441.2785.3.camel@achroite

Versions newest first

  1. v1 Latest27 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/27sfc: Remove redundant header gmii.hdrivers/net/sfc/falcon_gmac.c drivers/net/sfc/gmii.h+0 -610 replies
2/27sfc: Remove redundant hardware initialisationdrivers/net/sfc/falcon.c+0 -40 replies
3/27sfc: Rename Falcon-specific board code and typesdrivers/net/sfc/Makefile drivers/net/sfc/boards.h drivers/net/sfc/falcon.c +2 more+25 -260 replies
4/27sfc: Merge sfe4001.c into falcon_boards.cdrivers/net/sfc/Makefile drivers/net/sfc/boards.h drivers/net/sfc/falcon_boards.c +1 more+420 -4430 replies
5/27sfc: Remove boards.h, moving last remaining declaration to falcon.hdrivers/net/sfc/boards.h drivers/net/sfc/falcon.c drivers/net/sfc/falcon.h +6 more+2 -220 replies
6/27sfc: Remove versioned bitfield macrosdrivers/net/sfc/bitfield.h drivers/net/sfc/falcon.c drivers/net/sfc/falcon_hwdefs.h+47 -400 replies
7/27sfc: Move RX data FIFO thresholds out of struct efx_nic_typedrivers/net/sfc/falcon.c drivers/net/sfc/net_driver.h+12 -150 replies
8/27sfc: Update hardware definitions for Sienadrivers/net/sfc/falcon.c drivers/net/sfc/falcon_boards.c drivers/net/sfc/falcon_gmac.c +4 more+3756 -18870 replies
9/27sfc: Rename register I/O header and functions used by both Falcon and Sienadrivers/net/sfc/falcon.c drivers/net/sfc/falcon_boards.c drivers/net/sfc/falcon_gmac.c +4 more+426 -4210 replies
10/27sfc: Eliminate indirect lookups of queue size constantsdrivers/net/sfc/efx.c drivers/net/sfc/efx.h drivers/net/sfc/falcon.c +4 more+62 -980 replies
11/27sfc: Define DMA address mask explicitly in terms of descriptor field widthdrivers/net/sfc/falcon.c+2 -50 replies
12/27sfc: Move all TX DMA length limiting into tx.cdrivers/net/sfc/falcon.c drivers/net/sfc/net_driver.h drivers/net/sfc/tx.c +1 more+25 -250 replies
13/27sfc: Merge struct efx_blinker into struct efx_boarddrivers/net/sfc/falcon_boards.c drivers/net/sfc/net_driver.h+21 -290 replies
14/27sfc: Change order of device removal to reverse of probe orderdrivers/net/sfc/efx.c+1 -10 replies
15/27sfc: Remove declarations of nonexistent functionsdrivers/net/sfc/falcon.h+0 -20 replies
16/27sfc: Move efx_xmit_done() declaration into correct stanzadrivers/net/sfc/efx.h+1 -10 replies
17/27sfc: Move shared members of struct falcon_nic_data into struct efx_nicdrivers/net/sfc/falcon.c drivers/net/sfc/net_driver.h+14 -160 replies
18/27sfc: Maintain interrupt moderation values in ticks, not microsecondsdrivers/net/sfc/efx.c drivers/net/sfc/ethtool.c drivers/net/sfc/falcon.c +1 more+28 -340 replies
19/27sfc: Removed kernel-doc for nonexistent member of efx_phy_operationsdrivers/net/sfc/net_driver.h+0 -10 replies
20/27sfc: Remove pointless abstraction of memory BAR numberdrivers/net/sfc/efx.c drivers/net/sfc/efx.h drivers/net/sfc/falcon.c+10 -110 replies
21/27sfc: Merge falcon_probe_phy() into falcon_probe_port()drivers/net/sfc/falcon.c+25 -350 replies
22/27sfc: Remove incorrect assertion from efx_pci_remove_main()drivers/net/sfc/efx.c+0 -20 replies
23/27sfc: Remove unnecessary tests of efx->membasedrivers/net/sfc/efx.c+0 -80 replies
24/27sfc: Move MTD probe after netdev registration and name allocationdrivers/net/sfc/efx.c+4 -20 replies
25/27sfc: Merge efx_fc_resolve() into efx_mdio_get_pause()drivers/net/sfc/mdio_10g.c drivers/net/sfc/net_driver.h+8 -150 replies
26/27sfc: Remove unused code for non-autoneg speed/duplex switchingdrivers/net/sfc/mdio_10g.c+39 -690 replies
27/27sfc: Rename 'xfp' file and functions to reflect realitydrivers/net/sfc/Makefile drivers/net/sfc/falcon.c drivers/net/sfc/falcon_boards.c +2 more+58 -580 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/27] sfc: Cleanup and preparation for new hardware

David,

This is a mixture of small cleanups, refactoring, renaming and an update to the register definitions. There's more to come, in particular support for the new hardware, but I'll let you digest this batch first.

Ben.

Ben Hutchings (27):
sfc: Remove redundant header gmii.h
sfc: Remove redundant hardware initialisation
sfc: Rename Falcon-specific board code and types
sfc: Merge sfe4001.c into falcon_boards.c
sfc: Remove boards.h, moving last remaining declaration to falcon.h
sfc: Remove versioned bitfield macros
sfc: Move RX data FIFO thresholds out of struct efx_nic_type
sfc: Update hardware definitions for Siena
sfc: Rename register I/O header and functions used by both Falcon and
Siena
sfc: Eliminate indirect lookups of queue size constants
sfc: Define DMA address mask explicitly in terms of descriptor field
width
sfc: Move all TX DMA length limiting into tx.c
sfc: Merge struct efx_blinker into struct efx_board
sfc: Change order of device removal to reverse of probe order
sfc: Remove declarations of nonexistent functions
sfc: Move efx_xmit_done() declaration into correct stanza
sfc: Move shared members of struct falcon_nic_data into struct
efx_nic
sfc: Maintain interrupt moderation values in ticks, not microseconds
sfc: Removed kernel-doc for nonexistent member of efx_phy_operations
sfc: Remove pointless abstraction of memory BAR number
sfc: Merge falcon_probe_phy() into falcon_probe_port()
sfc: Remove incorrect assertion from efx_pci_remove_main()
sfc: Remove unnecessary tests of efx->membase
sfc: Move MTD probe after netdev registration and name allocation
sfc: Merge efx_fc_resolve() into efx_mdio_get_pause()
sfc: Remove unused code for non-autoneg speed/duplex switching
sfc: Rename 'xfp' file and functions to reflect reality

 drivers/net/sfc/Makefile                    |    4 +-
 drivers/net/sfc/bitfield.h                  |   13 -
 drivers/net/sfc/boards.c                    |  328 ---
 drivers/net/sfc/boards.h                    |   28 -
 drivers/net/sfc/efx.c                       |   89 +-
 drivers/net/sfc/efx.h                       |   11 +-
 drivers/net/sfc/ethtool.c                   |    8 +-
 drivers/net/sfc/falcon.c                    | 1122 +++++-----
 drivers/net/sfc/falcon.h                    |    4 +-
 drivers/net/sfc/falcon_boards.c             |  752 +++++++
 drivers/net/sfc/falcon_gmac.c               |   95 +-
 drivers/net/sfc/falcon_hwdefs.h             | 1333 -----------
 drivers/net/sfc/falcon_io.h                 |  258 ---
 drivers/net/sfc/falcon_xmac.c               |  178 +-
 drivers/net/sfc/gmii.h                      |   60 -
 drivers/net/sfc/io.h                        |  256 +++
 drivers/net/sfc/mdio_10g.c                  |  121 +-
 drivers/net/sfc/mdio_10g.h                  |    1 -
 drivers/net/sfc/net_driver.h                |   56 +-
 drivers/net/sfc/phy.h                       |    6 +-
 drivers/net/sfc/{xfp_phy.c => qt202x_phy.c} |   80 +-
 drivers/net/sfc/regs.h                      | 3180 +++++++++++++++++++++++++++
 drivers/net/sfc/rx.c                        |   16 +-
 drivers/net/sfc/selftest.c                  |    5 +-
 drivers/net/sfc/sfe4001.c                   |  435 ----
 drivers/net/sfc/tenxpress.c                 |    3 +-
 drivers/net/sfc/tx.c                        |   83 +-
 drivers/net/sfc/workarounds.h               |    2 +
 28 files changed, 5091 insertions(+), 3436 deletions(-)
 delete mode 100644 drivers/net/sfc/boards.c
 delete mode 100644 drivers/net/sfc/boards.h
 create mode 100644 drivers/net/sfc/falcon_boards.c
 delete mode 100644 drivers/net/sfc/falcon_hwdefs.h
 delete mode 100644 drivers/net/sfc/falcon_io.h
 delete mode 100644 drivers/net/sfc/gmii.h
 create mode 100644 drivers/net/sfc/io.h
 rename drivers/net/sfc/{xfp_phy.c => qt202x_phy.c} (73%)
 create mode 100644 drivers/net/sfc/regs.h
 delete mode 100644 drivers/net/sfc/sfe4001.c
Signature · 3 lines
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.