Skip to content

nfs-utils: add testing infrastructure to nfs-utils

Jeff Layton linux-nfs 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2nfs-utils: introduce new statd testing simulatorMakefile.am configure.ac tests/Makefile.am +4 more+571 -20 replies
2/2nfs-utils: add initial tests for statd that run via "make check"tests/Makefile.am tests/t0001-statd-basic-mon-unmon.sh tests/test-lib.sh+99 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] nfs-utils: add testing infrastructure to nfs-utils

This patchset is intended as a starting point for an automated test suite for nfs-utils. The idea here is to start simply and add a suite of tests that we can run via "make check" -- the standard automake method for running tests.

Clearly there are limits to what we can test with out a multi-host test harness, but my hope is that this should keep us from breaking basic functionality by allowing us to test it in a very simple fashion. At some point in the future we should also consider how to best handle multi-machine testing, but I see that as complimenting this code rather than replacing it.

For this set, the focus is on testing statd, which is particularly susceptible to subtle breakage. Problems with it are often not noticed until lock recovery breaks, and that may greatly lag the actual breakage.

To faciitate statd testing, I've added a "statdtest" program that can serve as a synthetic statd client and an NLM simulator. It's very loosely based on the old statd simulator code. That program is dependent on some of Chuck's recent statd patches -- notably the ones that break out common NSM code into libnsm.a.

For this initial drop, I'm just adding a single test that tests mon and unmon functionality with statd. Adding more tests shouldn't be too hard, however.

At this point, I'm mostly interested in general feedback on the concept. Does this seem like a reasonable starting point for automated nfs-utils

Jeff Layton (2):
nfs-utils: introduce new statd testing simulator
nfs-utils: add initial tests for statd that run via "make check"

 Makefile.am                          |    2 +-
 configure.ac                         |    4 +-
 tests/Makefile.am                    |    7 +
 tests/statdtest/Makefile.am          |   45 ++++
 tests/statdtest/README               |   12 +
 tests/statdtest/nlm_sm_inter.x       |   43 ++++
 tests/statdtest/statdtest.c          |  462 ++++++++++++++++++++++++++++++++++
 tests/t0001-statd-basic-mon-unmon.sh |   56 ++++
 tests/test-lib.sh                    |   41 +++
 9 files changed, 670 insertions(+), 2 deletions(-)
 create mode 100644 tests/Makefile.am
 create mode 100644 tests/statdtest/Makefile.am
 create mode 100644 tests/statdtest/README
 create mode 100644 tests/statdtest/nlm_sm_inter.x
 create mode 100644 tests/statdtest/statdtest.c
 create mode 100755 tests/t0001-statd-basic-mon-unmon.sh
 create mode 100755 tests/test-lib.sh