Skip to content

Fix packet queueing to allow full tap queue drain

Mark McLoughlin qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5tap: disable draining queue in one gonet/tap.c+13 -160 replies
2/5net: disable receiving if client returns zeronet.c net.h+39 -110 replies
3/5net/queue: queue packets even if sender doesn't supply a callbacknet/queue.c+3 -30 replies
4/5virtio-net: split the has_buffers() logic from can_receive()hw/virtio-net.c+12 -90 replies
5/5tap: drain queue in tap_send()net/tap.c+16 -133 replies

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by.

PatchSven Rudolph
1/5T-b
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/5] Fix packet queueing to allow full tap queue drain

Hey,
Scott points out that the current behaviour of draining the
entire queue in tap_send() doesn't work with non-virtio NICs because we drop a packet when the NIC queue fills up.

This series of patches first disables this behaviour, fixes
various aspects of the queueing logic and then re-enables the behaviour in a way that works with all NICs.

The first patch should also be applied to stable-0.11, I'll
follow up with a backport.

Scott, Sven, if you could test the tap-drain-queue branch from
my tree, that would be great:

http://repo.or.cz/w/qemu/markmc.git

Thanks,
Mark.