Skip to content

Expand usage of ckpt_err

serue-r/[email protected] containers 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7move handling of err down into _ckpt_do_msg and _appendcheckpoint/sys.c include/linux/checkpoint.h+39 -281 reply
2/7restart.c: use ckpt_errcheckpoint/restart.c+57 -243 replies
3/7process.c: use ckpt_err at restartcheckpoint/process.c+8 -81 reply
4/7files.c: ckpt_err() during restorecheckpoint/files.c+7 -10 replies
5/7kernel/cred.c: ckpt_err at restartkernel/cred.c+36 -102 replies
6/7have ckpt_err set ctx->errnocheckpoint/restart.c checkpoint/sys.c include/linux/checkpoint.h+40 -502 replies
7/7(debug) print vpids for all restarting taskscheckpoint/restart.c+1 -11 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/7] Expand usage of ckpt_err

From: Serge E. Hallyn <serue-r/[email protected]>

This patchset expands the usage of ckpt_err(). It moves the setting of ckpt_err (and CKPT_CTX_ERROR kflag) into ckpt_err() itself. It puts cktp_err()s in useful places for restart, and in some cases improves the information in the messages. It also splits the old 'restore_notify_error', which used to both set ctx->errno and wake all restarting tasks. Since we can pass an error to ckpt_err(), and there might be several ckpt_err()s along a failure path, we set ctx->errno only the first time, while we explicitly call restore_wake_all_on_error() at the end (of do_XYZ_task()) to actually wake the remaining tasks and notify them of the error.

The intent of this patchset is to provide an end-user with useful info when restart fails.

It is available as branch nov5.4 of
git://git.kernel.org/pub/scm/linux/kernel/git/sergeh/linux-cr.git (gitweb at
http://git.kernel.org/gitweb.cgi?p=linux/kernel/git/sergeh/linux-cr.git;a=shortlog;h=refs/heads/nov5.4
)

thanks,
-serge