RFC net, compat_ioctl: move handlers to net/socket.c
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest7 patches 4 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | compat: add struct compat_ifreq etc to compat.hinclude/ | +39 | 1 reply | |
| 2/7 | net/tun: handle compat_ioctl directlydrivers/ fs/ | +48 | 0 replies | |
| 3/7 | net, compat_ioctl: handle socket ioctl abuses in tty driversdrivers/ drivers/ drivers/ +3 more | +80 | 0 replies | |
| 4/7 | appletalk: handle SIOCATALKDIFADDR compat ioctlfs/ net/ | +7 | 0 replies | |
| 5/7 | copy socket ioctl code to net/socket.hnet/ | +717 | 0 replies | |
| 6/7 | compat: move sockios handling to net/socket.cfs/ net/ | +243 | 0 replies | |
| 7/7 | net, compat_ioctl: handle more ioctls correctlynet/ | +17 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC, PATCH 0/7] net, compat_ioctl: move handlers to net/socket.c
This cleans up some of the socket ioctl handling by moving it from fs/compat_ioctl.c to net/socket.c. The code is still untested, so this is an RFC for now. If you're happy with it, I'll do some testing to see if everything still works.
This series is a prerequisite for cleaning up the rest of compat_ioctl.c, saving some 30kb of kernel memory in the end.
The first four patches are probably worthwhile independently, because they fix some bugs in compat_ioctl handling. There is some obvious conflict with the ATM patch I sent independently today. That one should probably be worked out first.
Arnd <><
---
Arnd Bergmann (7):
compat: add struct compat_ifreq etc to compat.h net/tun: handle compat_ioctl directly
net, compat_ioctl: handle socket ioctl abuses in tty drivers appletalk:Â handle SIOCATALKDIFADDR compat ioctl copy socket ioctl code to net/socket.h
compat: move sockios handling to net/socket.c
net, compat_ioctl: handle more ioctls correctly
drivers/net/hamradio/6pack.c | 16 + drivers/net/hamradio/mkiss.c | 16 + drivers/net/slip.c | 21 ++ drivers/net/tun.c | 55 +++- drivers/net/wan/x25_asy.c | 15 + drivers/net/wireless/strip.c | 12 + fs/compat_ioctl.c | 745 ----------------------------------------- include/linux/compat.h | 39 +++ net/appletalk/ddp.c | 12 +- net/socket.c | 748 +++++++++++++++++++++++++++++++++++++++++- 10 files changed, 914 insertions(+), 765 deletions(-)