OMAP3:PM: T2 keypad: Wakeup with support for OFF mode
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | OMAP3: PM: Add suspend-resume to TWL4030 keypaddrivers/ | +18 | 0 replies | |
| 2/4 | OMAP3: PM: T2 keypad: Add board specific suspend-resume functionsdrivers/ include/ | +22 | 0 replies | |
| 3/4 | OMAP3: PM: Wakeup from T2 keypad with OFF modearch/ | +89 | 0 replies | |
| 4/4 | OMAP3: PM: Extend T2 wakeup support to 3430SDParch/ | +89 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/4] OMAP3:PM: T2 keypad: Wakeup with support for OFF mode
This patch series incrementally adds support for wake-up from TWL4030 keypad when OFF mode is hot during suspend.
In the process, it extends existing driver to support board specific implementation during suspend and resume operations.
The patch has been tested on OMAP3EVM and would be good to find if it works on the 3430SDP as well.
TODO:
The structire 'omap_keypad_pm_state' is being defined (and duplicated) in board specific files - board-omap3evm.c and board-3430sdp.c.
This definition should ideally be in a header file, but matrix_keypad.h is not the right one. Also, plat/keypad.h is no longer used (inclusion results in warnings for duplicate definitions).
Possible alternatives:
- Cleanup plat/keypad.h - Not sure if it is being used by any other platform.
- Create a new header file alongside the board files for TWL4030 keypad. (Much of existing duplication also gets addressed).
Either of these alternatives can be taken as a separate patch. OR, as follow-up to last 2 patches in this series. Thoughts?
Sanjeev Premi (4):
OMAP3: PM: Add suspend-resume to TWL4030 keypad
OMAP3: PM: T2 keypad: Add board specific suspend-resume functions
OMAP3: PM: Wakeup from T2 keypad with OFF mode
OMAP3: PM: Extend T2 wakeup support to 3430SDP
arch/arm/mach-omap2/board-3430sdp.c | 89 +++++++++++++++++++++++++++++++ arch/arm/mach-omap2/board-omap3evm.c | 89 +++++++++++++++++++++++++++++++ drivers/input/keyboard/twl4030_keypad.c | 28 ++++++++++ include/linux/i2c/twl4030.h | 12 ++++ 4 files changed, 218 insertions(+), 0 deletions(-)