Skip to content

RFC Fix qemu_announce_self() properly

Mark McLoughlin qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest7 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7net: remove NICInfo::vchw/dp8393x.c hw/etraxfs_eth.c hw/mcf_fec.c +3 more+27 -280 replies
2/7qdev: add "net-client" propertyhw/qdev-properties.c hw/qdev.h net.h+35 -31 reply
3/7net: create the VLANClientState for NICs earlyhw/dp8393x.c hw/e1000.c hw/eepro100.c +16 more+97 -861 reply
4/7net: kill off NICInfo/NICConf::vlan/netdevhw/integratorcp.c hw/mcf5208.c hw/mips_mipssim.c +9 more+29 -1150 replies
5/7qdev: add qdev_foreach()hw/qdev.c hw/qdev.h+23 -03 replies
6/7qdev: add qdev_prop_get_{macaddr, net_client}()hw/qdev-properties.c hw/qdev.h+31 -30 replies
7/7net: fix qemu_announce_self()savevm.c+26 -172 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [RFC PATCH 0/7] Fix qemu_announce_self() properly

Hi,
The recent "fix" to qemu_announce_self() will segfault if you use
-netdev. The real root cause of the regression was the removal of the assignment to NICInfo::vc that used to live in qdev_get_vlan_client().

Now that NICs are qdev-ified, we should just iterate over the
qdev tree to find NICs and send out the announce packet from each.

This series does just that. I've only lightly tested it, more
testing and comments welcome.

Pushed to the fix-announce-self-rfc branch at:

git://repo.or.cz/qemu/markmc.git

Cheers,
Mark.