RFC Fix qemu_announce_self() properly
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest7 patches 7 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | net: remove NICInfo::vchw/ hw/ hw/ +3 more | +27 | 0 replies | |
| 2/7 | qdev: add "net-client" propertyhw/ hw/ net.h | +35 | 1 reply | |
| 3/7 | net: create the VLANClientState for NICs earlyhw/ hw/ hw/ +16 more | +97 | 1 reply | |
| 4/7 | net: kill off NICInfo/NICConf::vlan/netdevhw/ hw/ hw/ +9 more | +29 | 0 replies | |
| 5/7 | qdev: add qdev_foreach()hw/ hw/ | +23 | 3 replies | |
| 6/7 | qdev: add qdev_prop_get_{macaddr, net_client}()hw/ hw/ | +31 | 0 replies | |
| 7/7 | net: fix qemu_announce_self()savevm.c | +26 | 2 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [Qemu-devel] [RFC PATCH 0/7] Fix qemu_announce_self() properly
Hi,
The recent "fix" to qemu_announce_self() will segfault if you use
-netdev. The real root cause of the regression was the removal of the assignment to NICInfo::vc that used to live in qdev_get_vlan_client().
Now that NICs are qdev-ified, we should just iterate over the
qdev tree to find NICs and send out the announce packet from each.
This series does just that. I've only lightly tested it, more
testing and comments welcome.
Pushed to the fix-announce-self-rfc branch at:
git://repo.or.cz/qemu/markmc.git
Cheers,
Mark.