Skip to content

RFC compat-ioctl.c diet

Arnd Bergmann lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest4 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4compat_ioctl: inline all conversion handlersfs/compat_ioctl.c+81 -540 replies
2/4compat_ioctl: simplify calling of handlersfs/compat_ioctl.c+39 -470 replies
3/4compat_ioctl: simplify lookup tablefs/compat_ioctl.c+41 -460 replies
4/4compat_ioctl: pass compat pointer directly to handlersfs/compat_ioctl.c+83 -1280 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 0/4] compat-ioctl.c diet

I've spent some time on making the compat ioctl code significantly smaller. Removing the tty and socket level ioctl handling from common code in linux-next helps a bit, but mostly just moves code to other places but does not save much in an allyesconfig.

This is the output of /usr/bin/size on the fs/compat_ioctl.o file in different versions:

2.6.32-rc7:
text data bss dec hex filename
13335 17792 2080 33207 81b7 obj/fs/compat_ioctl.o
linux-next:
8877 14696 2080 25653 6435 obj/fs/compat_ioctl.o
Simplifying the remaining code (this series):
7572 2144 4 9720 25f8 obj/fs/compat_ioctl.o
Moving more handlers directly into driver (future series):
4817 1740 4 6561 19a1 obj/fs/compat_ioctl.o

There are a few dependencies on code in other trees, so this series doesn't currently apply cleanly anywhere except my own tree.

The final series of patches that I'll post separately depends on this one as well and touches most of the drivers that currently require a conversion function in fs/compat_ioctl.c that no other driver uses. Moving those conversions into the drivers simplifies the common code and keeps the native and compat versions closer.

	Arnd <><

---

Arnd Bergmann (4):
compat_ioctl: inline all conversion handlers
compat_ioctl: simplify calling of handlers
compat_ioctl: simplify lookup table
compat_ioctl: pass compat pointer directly to handlers

 fs/compat_ioctl.c |  471 +++++++++++++++++++++++++----------------------------
 1 files changed, 220 insertions(+), 251 deletions(-)