Skip to content

Fix announce_self(), misc net fixes and cleanups

Mark McLoughlin qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest44 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/44net: move slirp code from net.c to net/slirp.cMakefile monitor.c net.c +4 more+814 -7180 replies
2/44net: move vde code from net.c to net/vde.cMakefile net.c net/vde.c +1 more+162 -1010 replies
3/44net: move socket backend code from net.c to net/socket.cMakefile net.c net/socket.c +1 more+596 -5290 replies
4/44net: move dump backend code from net.c to net/dump.cMakefile net.c net/dump.c +1 more+186 -1260 replies
5/44net: clean up includes in net.cnet.c+3 -730 replies
6/44net: remove NICInfo::vchw/dp8393x.c hw/etraxfs_eth.c hw/mcf_fec.c +3 more+27 -280 replies
7/44net: remove NICInfo::privatenet.h+0 -10 replies
8/44net: introduce NetClientInfonet.h+11 -00 replies
9/44net: introduce qemu_new_net_client()net.c net.h+54 -212 replies
10/44qdev: move DO_UPCAST() into osdep.hhw/qdev.h osdep.h+10 -100 replies
11/44net: convert tap to NetClientInfonet/tap.c+45 -370 replies
12/44net: convert tap-win32 to NetClientInfonet/tap-win32.c+23 -160 replies
13/44net: convert slirp to NetClientInfonet/slirp.c+37 -240 replies
14/44net: convert vde to NetClientInfonet/vde.c+28 -170 replies
15/44net: convert socket to NetClientInfonet/socket.c+45 -290 replies
16/44net: convert dump to NetClientInfonet/dump.c+27 -200 replies
17/44net: introduce NICState and qemu_new_nic()net.c net.h+32 -00 replies
18/44net: convert virtio to NICStatehw/virtio-net.c+39 -340 replies
19/44net: convert e1000 to NICStatehw/e1000.c+26 -210 replies
20/44net: convert rtl8139 to NICStatehw/rtl8139.c+24 -190 replies
21/44net: convert ne2000 to NICStatehw/ne2000-isa.c hw/ne2000.c hw/ne2000.h+36 -230 replies
22/44net: convert pcnet to NICStatehw/lance.c hw/pcnet.c hw/pcnet.h+38 -260 replies
23/44net: convert eepro100 to NICStatehw/eepro100.c+24 -190 replies
24/44net: convert dp8393x to NICStatehw/dp8393x.c+25 -160 replies
25/44net: convert etrax to NICStatehw/etraxfs_eth.c+27 -180 replies
26/44net: convert LAN9118 to NICStatehw/lan9118.c+25 -200 replies
27/44net: convert mcf_fec to NICStatehw/mcf_fec.c+33 -250 replies
28/44net: convert mipsnet to NICStatehw/mipsnet.c+27 -180 replies
29/44net: convert musicpal to NICStatehw/musicpal.c+18 -130 replies
30/44net: convert smc91c111 to NICStatehw/smc91c111.c+20 -150 replies
31/44net: convert stellaris to NICStatehw/stellaris_enet.c+19 -150 replies
32/44net: convert usb-net to NICStatehw/usb-net.c+31 -260 replies
33/44net: convert xilinx_ethlite to NICStatehw/xilinx_ethlite.c+20 -150 replies
34/44net: move parse_macaddr() to net/util.[ch]Makefile net.c net/util.c +1 more+95 -340 replies
35/44net: convert xen to NICStatehw/xen_nic.c+29 -170 replies
36/44net: remove qemu_new_vlan_client()net.c net.h+0 -570 replies
37/44net: remove VLANClientState members now in NetClientInfohw/dp8393x.c hw/virtio-net.c net.c +2 more+27 -400 replies
38/44net: add qemu_foreach_nic()net.c net.h+22 -00 replies
39/44net: fix qemu_announce_self()savevm.c+13 -130 replies
40/44net: print correct error for '-netdev ""'net.c+11 -50 replies
41/44net: fix TAP networking on host kernels without IFF_VNET_HDR supportnet/tap-linux.c+2 -00 replies
42/44net: check for TUNSETOFFLOAD support before trying to enable offload featuresnet/tap-linux.c+5 -00 replies
43/44net: initialize vnet_hdr in net_init_tap()net/tap.c+1 -10 replies
44/44net: fix vnet_hdr handling in solaris tap codenet/tap-solaris.c+11 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 00/44] Fix announce_self(), misc net fixes and cleanups

Hi,
Here's a new series of patches mainly to fix qemu_announce_self()
with -netdev as discussed earlier on the list.

I would have liked to have split the series in three, but there
would be conflicts between each, so here goes:

1) Patches 01 to 05 - net.c cleanups

These patches continue the job of moving net backends from net.c to individual files in the net/ directory

2) Patches 06 to 39 - fix qemu_annonuce_self()

The basic issue is that we need a sane way of iterating all the NICs on the system, obtaining the MAC address for each and inject a packet from each.

The series splits out the per-device-type data from VLANClientState into a new structure called NetClientInfo. It further allows devices to inherit from VLANClientState and introduces a NICState struct and qemu_new_nic() constructor for NICs.

That's a huge amount of churn just to fix qemu_announce_self(), but I think the end result is a very nice cleanup to the net API.

3) Patches 40 to 44 - misc fixes

Some small misc networking fixes, including the two posted by Pierre Riteau earlier.

I've given all this quite a bit of compile and runtime testing
and it seems in good shape.

Thanks,
Mark.