Skip to content

nilfs2: reduce redundant mark_inode_dirty

Jiro SEKIBA linux-nilfs 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 1 replyIn review
  2. v19 patches 5 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9nilfs2: delete mark_inode_dirty in nilfs_new_inodefs/nilfs2/inode.c fs/nilfs2/namei.c+1 -20 replies
2/9nilfs2: delete mark_inode_dirty from nilfs_set_linkfs/nilfs2/dir.c fs/nilfs2/namei.c+3 -20 replies
3/9nilfs2: expand inode_inc_link_count and inode_dec_link_countfs/nilfs2/namei.c+32 -170 replies
4/9nilfs2: delete redundant mark_inode_dirtyfs/nilfs2/namei.c+0 -40 replies
5/9nilfs2: split nilfs_unlink as nilfs_do_unlink and nilfs_unlinkfs/nilfs2/namei.c+19 -100 replies
6/9nilfs2: change return type of nilfs_commit_chunkfs/nilfs2/dir.c+8 -80 replies
7/9nilfs2: delete mark_inode_dirty in nilfs_commit_chunkfs/nilfs2/dir.c fs/nilfs2/namei.c+2 -40 replies
8/9nilfs2: delete mark_inode_dirty in nilfs_delete_entryfs/nilfs2/dir.c fs/nilfs2/namei.c+2 -20 replies
9/9nilfs2: replace mark_inode_dirty as nilfs_mark_inode_dirtyfs/nilfs2/dir.c fs/nilfs2/inode.c fs/nilfs2/namei.c+20 -200 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCHv2 0/9] nilfs2: reduce redundant mark_inode_dirty

Hi,

This is a revised series of patches to reduce redandunt mark_inode_dirty calls.

Many functions call mark_inode_dirty() whenever they change inode object. However, it is redundant to call mark_inode_dirty() to same inode object within a transaction.

Last patch also replaces all mark_inode_dirty() calls as nilfs_mark_inode_dirty(), to reduce deep function call tree.

Changes since v2 is:
- deleted mark_inode_dirty(dir) in nilfs_mkdir()
- moved mark_inod_dirty(dir) from nilfs_do_unlink() to nilfs_unlink()
- correct diff stat ;-)

 fs/nilfs2/dir.c   |   24 ++++++---------
 fs/nilfs2/inode.c |    7 ++--
 fs/nilfs2/namei.c |   83 +++++++++++++++++++++++++++++++++-------------------
 3 files changed, 66 insertions(+), 48 deletions(-)