Skip to content

QError conversions and more

Markus Armbruster qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest18 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18QError: new class for device encrypted errorsqerror.c qerror.h+7 -00 replies
2/18monitor: do_cont(): Don't ask for passwordsmonitor.c+9 -10 replies
3/18monitor: Fix double-prompt after "change vnc passwd BLA"monitor.c+8 -30 replies
4/18QError: Put error definitions in alphabetical orderqerror.c qerror.h+29 -290 replies
5/18QError: New QERR_DEVICE_LOCKEDqerror.c qerror.h+7 -00 replies
6/18QError: New QERR_DEVICE_NOT_REMOVABLEqerror.c qerror.h+7 -00 replies
7/18monitor: convert do_eject() to QErrormonitor.c+4 -30 replies
8/18QError: New QERR_INVALID_BLOCK_FORMATqerror.c qerror.h+7 -00 replies
9/18QError: New QERR_SET_PASSWD_FAILEDqerror.c qerror.h+7 -00 replies
10/18QError: New QERR_VNC_SERVER_FAILEDqerror.c qerror.h+7 -00 replies
11/18monitor: convert do_change() to QObject, QErrormonitor.c qemu-monitor.hx+13 -90 replies
12/18QError: New QERR_FD_NOT_FOUNDqerror.c qerror.h+7 -02 replies
13/18monitor: convert do_closefd() to QErrormonitor.c+1 -20 replies
14/18QError: New QERR_FD_NOT_SUPPLIEDqerror.c qerror.h+7 -00 replies
15/18New QERR_INVALID_PARAMETERqerror.c qerror.h+7 -00 replies
16/18QError: New QERR_TOO_MANY_FILESqerror.c qerror.h+7 -00 replies
17/18monitor: convert do_getfd() to QErrormonitor.c+6 -40 replies
18/18QMP: add human-readable description to error responseQMP/qmp-spec.txt monitor.c qerror.c +1 more+23 -69 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [FOR 0.12 PATCH 00/18] QError conversions and more

This patch series converts monitor commands eject, change, closefd, getfd to QError.

There's a simple bonus fix in PATCH 3.

Finally, PATCH 18 puts a human-readable error description into the QMP error response. For background, see the lengthy thread ending at
http://lists.gnu.org/archive/html/qemu-devel/2009-11/msg01221.html

Series should be applied after Luiz's work.

Luiz Capitulino (2):
QError: new class for device encrypted errors
monitor: do_cont(): Don't ask for passwords

Markus Armbruster (16):
monitor: Fix double-prompt after "change vnc passwd BLA"
QError: Put error definitions in alphabetical order
QError: New QERR_DEVICE_LOCKED
QError: New QERR_DEVICE_NOT_REMOVABLE
monitor: convert do_eject() to QError
QError: New QERR_INVALID_BLOCK_FORMAT
QError: New QERR_SET_PASSWD_FAILED
QError: New QERR_VNC_SERVER_FAILED
monitor: convert do_change() to QObject, QError
QError: New QERR_FD_NOT_FOUND
monitor: convert do_closefd() to QError
QError: New QERR_FD_NOT_SUPPLIED
New QERR_INVALID_PARAMETER
QError: New QERR_TOO_MANY_FILES
monitor: convert do_getfd() to QError
QMP: add human-readable description to error response

 QMP/qmp-spec.txt |    5 ++-
 monitor.c        |   55 +++++++++++++++++++++++-----------
 qemu-monitor.hx  |    3 +-
 qerror.c         |   85 +++++++++++++++++++++++++++++++++++++++++++-----------
 qerror.h         |   56 ++++++++++++++++++++++++++++-------
 5 files changed, 155 insertions(+), 49 deletions(-)