Skip to content

reiserfs lock inversion fixes on xattr

Frederic Weisbecker lkml reiserfs-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5reiserfs: Relax lock before open xattr dir in reiserfs_xattr_set_handle()fs/reiserfs/xattr.c+7 -20 replies
2/5reiserfs: Fix unwanted recursive reiserfs lock in reiserfs_unlink()fs/reiserfs/namei.c+4 -30 replies
3/5reiserfs: Fix journal mutex <-> inode mutex lock inversionfs/reiserfs/xattr.c+2 -10 replies
4/5reiserfs: Safely acquire i_mutex from reiserfs_for_each_xattrfs/reiserfs/xattr.c+3 -20 replies
5/5reiserfs: Safely acquire i_mutex from xattr_rmdirfs/reiserfs/xattr.c+2 -10 replies

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by.

PatchChristian Kujau
SeriesT-b
1/5
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] reiserfs lock inversion fixes on xattr

Hi,

Christian Kujau's use of dbench to test reiserfs xattr has inspired me. I tried dbench -x yesterday and got various soft-lockups and lockdep reports.

I fixed all those I've seen in this batch and it passed through 6 hours of stress testing (if a loop of dbench -x -t 60 20 can be called stress testing) and things look pretty fine now.

I hope you can give it a try (and/or review) before I send the whole to Linus.

Thanks!

It's on:

git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing.git
reiserfs/kill-bkl

How to get it:

git-clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
cd linux-2.6.git
git-pull git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing.git reiserfs/kill-bkl

Frederic Weisbecker (5):
reiserfs: Relax lock before open xattr dir in reiserfs_xattr_set_handle()
reiserfs: Fix unwanted recursive reiserfs lock in reiserfs_unlink()
reiserfs: Fix journal mutex <-> inode mutex lock inversion
reiserfs: Safely acquire i_mutex from reiserfs_for_each_xattr
reiserfs: Safely acquire i_mutex from xattr_rmdir

 fs/reiserfs/namei.c |    7 ++++---
 fs/reiserfs/xattr.c |   20 ++++++++++++++------
 2 files changed, 18 insertions(+), 9 deletions(-)