Skip to content

Support for MPC512x FEC

Anatolij Gustschin linuxppc-dev netdev 4 versions – Applied

Status from this message: Applied, for real this time! :-)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest posting 2/23 patches 1 replyApplied
  2. v23 patches 8 repliesSuperseded
  3. v3 posting 1/211 patches 15 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v10 of 8 patches1 replySuperseded

Changes since previous version from the cover letter

- don't attempt to provide runtime selection of MPC5121 FEC support in the driver since it doesn't make sense. Select MPC5121 FEC support at compile time.
- fix tx buffer alignment workaround patch to align only misaligned buffers.
- address Eric's comments:

Patches in v3 posting 2/2 Applied

#Subject and filesSizeRepliesApplied
1/3fs_enet: use dev_xxx instead of printkdrivers/net/fs_enet/fs_enet-main.c drivers/net/fs_enet/mac-fcc.c drivers/net/fs_enet/mac-fec.c +1 more+27 -380 replies
2/3fs_enet: Add support for MPC512x to fs_enet driverdrivers/net/fs_enet/Kconfig drivers/net/fs_enet/fs_enet-main.c drivers/net/fs_enet/fs_enet.h +2 more+95 -210 replies
3/3fs_enet: add FEC TX buffer alignment workaround for MPC5121drivers/net/fs_enet/fs_enet-main.c+47 -00 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchGrant Likely
1/3A-b
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [net-next-2.6 PATCH v3 0/3] Support for MPC512x FEC

These patches attempt to provide support for the Freescale MPC512x FEC in the fs_enet driver. The first cleanup patch replaces printk by dev_xxx. The second and third attemt to support MPC5121 FEC in the FEC driver.

Changes since previous version:

- don't attempt to provide runtime selection of MPC5121 FEC support in the driver since it doesn't make sense. Select MPC5121 FEC support at compile time.
- fix tx buffer alignment workaround patch to align only misaligned buffers.
- address Eric's comments:

	ratelimit warning message and
	use 4-byte aligned skb->len for new properly
	aligned skb.

The patches are based on net-next-2.6 and has been tested on the:
- Freescale/STX "MPC5121ADS" board (board rev. 4) with

     a MPC5121e Rev. 2.

- TQM860L and TQM855 boards.

Anatolij Gustschin (3):
fs_enet: use dev_xxx instead of printk
fs_enet: Add support for MPC512x to fs_enet driver
fs_enet: add FEC TX buffer alignment workaround for MPC5121

 drivers/net/fs_enet/Kconfig        |   10 +++-
 drivers/net/fs_enet/fs_enet-main.c |   93 ++++++++++++++++++++++++++---------
 drivers/net/fs_enet/fs_enet.h      |   49 ++++++++++++++++++-
 drivers/net/fs_enet/mac-fcc.c      |    5 +-
 drivers/net/fs_enet/mac-fec.c      |   58 ++++++++++++++--------
 drivers/net/fs_enet/mac-scc.c      |    9 ++--
 drivers/net/fs_enet/mii-fec.c      |    4 +-
 7 files changed, 169 insertions(+), 59 deletions(-)