Skip to content

i386 cpuid: cleanup and fixes

Andre Przywara qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest13 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13cpuid: move CPUID functions into separate fileMakefile.target target-i386/cpu.h target-i386/cpuid.c +1 more+827 -7791 reply
2/13cpuid: replace magic number with named constanttarget-i386/cpuid.c+6 -51 reply
3/13cpuid: moved host_cpuid function and remove prototypetarget-i386/cpuid.c+34 -361 reply
4/13cpuid: Replace strtok with get_opt_nametarget-i386/cpuid.c+24 -100 replies
5/13cpuid: add missing CPUID feature flag namestarget-i386/cpuid.c+8 -71 reply
6/13cpuid: list all known x86 CPUID feature flagstarget-i386/cpuid.c+21 -10 replies
7/13cpuid: remove unnecessary kvm_trim functiontarget-i386/kvm.c+6 -210 replies
8/13cpuid: simplify CPUID flag search functiontarget-i386/cpuid.c+14 -260 replies
9/13cpuid: propagate further CPUID leafs when -cpu hosttarget-i386/cpu.h target-i386/cpuid.c+26 -70 replies
10/13cpuid: add TCG feature bit trimmingtarget-i386/cpuid.c+26 -00 replies
11/13cpuid: Always expose 32 and 64-bit CPUstarget-i386/cpuid.c+0 -20 replies
12/13cpuid: Add kvm32 CPU modeltarget-i386/cpuid.c+14 -00 replies
13/13cpuid: fix CPUID levelstarget-i386/cpuid.c+2 -20 replies

Reviews trailers per patch

3 of 13 patches have a Reviewed-by or Acked-by.

PatchAurelien Jarno
1/13
2/13A-b
3/13A-b
4/13
5/13A-b
6/13
7/13
8/13
9/13
10/13
11/13
12/13
13/13

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 00/13] i386 cpuid: cleanup and fixes

Hi,

first: I know that this conflicts with John Cooper's latest patch, but I want to send this out for review and to help merging the stuff.

This patchset cleans up the CPUID handling code in QEMU. The biggest change is obviously the move of the CPUID function to a separate file (cpuid.c). This helps to split up a rather large source file, which's name (helper.c) is also a bit misleading.
Please tell me soon if you don't like it so that I can rebase the rest of patches.
Additionally the rest of the patches beautifies or simplifies some code. Feature additions are:
5/13: add missing CPUID feature bit names
6/13: list CPUID feature bit names when using -cpu ?
9/13: -cpu host propagates more CPUID leafs, so that the cache topology
will be visibile in the guest
10/13: add CPUID feature bit trimming for TCG: Features not supported by
the emulator will be masked out.
11/13: always show all CPU types: also expose the newer (64bit) CPU types
for the i386 emulator. 64bit features will be masked out due to 10/13.
12/13: add kvm32 CPU model: Per popular request add a counterpart to kvm64
describing a basic hardware virtualization capable CPU for migration purposes.

More details in the commit messages.

Note: In opposite to the last version I left out patches which change the CPUID bits of existing CPU models to avoid regressions with guests.

Please review and comment.

Regards,
Andre.