Skip to content

RFC cfg80211: Retrieve missing BSS info after connect

David Kilroy linux-wireless 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2cfg80211: generic trigger scan and callback on completionnet/wireless/core.h net/wireless/scan.c net/wireless/sme.c+46 -161 reply
2/2cfg80211: scan for missing BSS on connect completioninclude/net/cfg80211.h net/wireless/scan.c net/wireless/sme.c+132 -191 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 0/2] cfg80211: Retrieve missing BSS info after connect

This patchset attempts to address the issue where a driver that uses the cfg80211 connect operation connects to an AP before the scan result for the AP is available. This triggers a WARN_ON in sme.c, and the connection fails.

This is only an issue for drivers that do not pass beacons/probes to cfg80211, except in response to an explicit scan. With typical userspace the issue will only manifest if using iwconfig to connect, or if using wpa_supplicant with ap_scan=2 (which you might do with a hidden SSID).

The patches were originally written for the orinoco cfg80211 conversion (currently stalled due to lack of time). It sounds like the libertas cfg80211 drivers have the same problem, so I'm posting them in case they're useful. There's a bit of cleanup to do, and there may be issues with the setting of the channels to scan (orinoco can't scan by channel) so if someone wants to pick these up, please do.

Testing
- a version of this has been running with my orinoco changes for the last 3 or 4 months (in more or less daily use).
- Untested against drivers that don't use ->connect

---
David Kilroy (2):
cfg80211: generic trigger scan and callback on completion
cfg80211: scan for missing BSS on connect completion

 include/net/cfg80211.h |    3 +
 net/wireless/core.h    |    6 ++
 net/wireless/scan.c    |   41 ++++++++++++-
 net/wireless/sme.c     |  163 ++++++++++++++++++++++++++++++++++++++----------
 4 files changed, 178 insertions(+), 35 deletions(-)