Skip to content

adds include/asm-generic/pci-dma-common.h

[email protected] lkml 1 version In review

Get series with b4
b4 am 1265722524-9493-1-git-send-email-e

Versions newest first

  1. v1 Latest12 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12adds include/asm-generic/pci-dma-common.hinclude/asm-generic/pci-dma-common.h+20 -00 replies
2/12x86: use asm-generic/pci-dma-common.harch/x86/include/asm/pci.h+2 -250 replies
3/12alpha: use asm-generic/pci-dma-common.harch/alpha/include/asm/pci.h+2 -120 replies
4/12arm: use asm-generic/pci-dma-common.harch/arm/include/asm/pci.h+2 -60 replies
5/12frv: use asm-generic/pci-dma-common.harch/frv/include/asm/pci.h+1 -60 replies
6/12ia64: use asm-generic/pci-dma-common.harch/ia64/include/asm/pci.h+2 -120 replies
7/12mips: use asm-generic/pci-dma-common.harch/mips/include/asm/pci.h+3 -200 replies
8/12parisc: use asm-generic/pci-dma-common.harch/parisc/include/asm/pci.h+2 -120 replies
9/12powerpc: use asm-generic/pci-dma-common.harch/powerpc/include/asm/pci.h+3 -300 replies
10/12sh: use asm-generic/pci-dma-common.harch/sh/include/asm/pci.h+2 -130 replies
11/12sparc: use asm-generic/pci-dma-common.harch/sparc/include/asm/pci.h arch/sparc/include/asm/pci_32.h arch/sparc/include/asm/pci_64.h+3 -281 reply
12/12xtensa: use asm-generic/pci-dma-common.harch/xtensa/include/asm/pci.h+1 -60 replies

Reviews trailers per patch

1 of 12 patches has a Reviewed-by or Acked-by.

PatchDavid S. Miller
1/12
2/12
3/12
4/12
5/12
6/12
7/12
8/12
9/12
10/12
11/12A-b
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH -mm 00/12] adds include/asm-generic/pci-dma-common.h

This patchset adds include/asm-generic/pci-dma-common.h that defines the pci_unmap state API:

DECLARE_PCI_UNMAP_ADDR(ADDR_NAME)
DECLARE_PCI_UNMAP_LEN(LEN_NAME)
pci_unmap_addr(PTR, ADDR_NAME)
pci_unmap_addr_set(PTR, ADDR_NAME, VAL)
pci_unmap_len(PTR, LEN_NAME)
pci_unmap_len_set(PTR, LEN_NAME, VAL)

This enables us to remove lots of the duplication in architecture implementations since there are only two ways to define the API.

If architectures define HAVE_ARCH_PCI_UNMAP, they get the real definition of pci_unmap state API. If not, they get the noop definition.

In the long term, it's better to replace the API with the generic device model API such as DECLARE_DMA_UNMAP_ADDR. We can map the API to the generic one (like dma-mapping-compat.h does). This patch also makes the migration process easier.

=

 arch/alpha/include/asm/pci.h         |   14 ++------------
 arch/arm/include/asm/pci.h           |    8 ++------
 arch/frv/include/asm/pci.h           |    7 +------
 arch/ia64/include/asm/pci.h          |   14 ++------------
 arch/mips/include/asm/pci.h          |   23 +++--------------------
 arch/parisc/include/asm/pci.h        |   14 ++------------
 arch/powerpc/include/asm/pci.h       |   33 +++------------------------------
 arch/sh/include/asm/pci.h            |   15 ++-------------
 arch/sparc/include/asm/pci.h         |    3 +++
 arch/sparc/include/asm/pci_32.h      |   14 --------------
 arch/sparc/include/asm/pci_64.h      |   14 --------------
 arch/x86/include/asm/pci.h           |   27 ++-------------------------
 arch/xtensa/include/asm/pci.h        |    7 +------
 include/asm-generic/pci-dma-common.h |   20 ++++++++++++++++++++
 14 files changed, 43 insertions(+), 170 deletions(-)