Skip to content

Add infrastructure for metadata balancing.

Dave Wysochanski lvm-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest21 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/21Change 'filler' to 'flags' in on-disk 'raw_locn' structure.lib/format_text/layout.h+1 -10 replies
2/21Add text format specific 'rlocn' disable flag and access functions.include/.symlinks.in lib/format_text/format-text.c lib/format_text/format-text.h +1 more+25 -00 replies
3/21Add format independent flag and functions to disable mdas.lib/format_text/text_label.c lib/metadata/metadata.c lib/metadata/metadata.h+20 -00 replies
4/21Move dev_open / dev_close outside _vg_read_raw_area().lib/format_text/format-text.c+30 -100 replies
5/21Move dev_open/dev_close outside vgname_from_mda().lib/format_text/format-text.c lib/format_text/text_label.c+13 -130 replies
6/21Allow raw_read_mda_header to be called from text_label.c.lib/format_text/format-text.c lib/format_text/format-text.h lib/format_text/layout.h +1 more+37 -160 replies
7/21Ensure in-memory state matches on-disk state of mda disable bit.lib/format_text/format-text.c lib/format_text/text_label.c+5 -00 replies
8/21Add vg field to struct physical_volume and find_vg_by_pv().lib/format_text/import_vsn1.c lib/metadata/metadata-exported.h lib/metadata/metadata.c+8 -00 replies
9/21Add mda_locn_match() internal library function.lib/format_text/format-text.c lib/metadata/metadata.c lib/metadata/metadata.h+52 -00 replies
10/21Define new functions and vgs/pvs fields related to mda disable/enable.lib/metadata/metadata-exported.h lib/metadata/metadata.c lib/report/columns.h +1 more+120 -00 replies
11/21Add --metadatadisable to pvchange, allowing for disabling of metadata areas.tools/args.h tools/commands.h tools/pvchange.c+32 -20 replies
12/21Update pvchange, pvs and vgs man pages for metadata disable.man/pvchange.8.in man/pvs.8.in man/vgs.8.in+8 -30 replies
13/21Add tests for metadata balance - set/clear/display per-PV disable bit.test/t-metadata-balance.sh+41 -00 replies
14/21Add metadata balance arguments, update vgcreate man page and help.man/vgcreate.8.in tools/args.h tools/commands.h+33 -20 replies
15/21Add vg metadata balance parameters with defaults.lib/config/defaults.h lib/metadata/metadata-exported.h lib/metadata/metadata.c +1 more+21 -00 replies
16/21Add vg get/set methods for metadata balance min/max.lib/metadata/metadata-exported.h lib/metadata/metadata.c+59 -00 replies
17/21Make metadata_balance_{min|max} persistent on disk.lib/format_text/export.c lib/format_text/import_vsn1.c+16 -00 replies
18/21Add vg_mda_balance_{min|max} display fields to 'vgs' command.lib/report/columns.h lib/report/report.c+26 -00 replies
19/21Add vg metadata balance parameters to vgchange man page and help.man/vgchange.8.in tools/commands.h+27 -00 replies
20/21Update vgchange tool to handle metadata balance min/max.tools/vgchange.c+76 -10 replies
21/21Update metadatabalance tests to include sanity checks for vgchange.test/t-metadata-balance.sh+25 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/21] Add infrastructure for metadata balancing.

This patchset is a third round of the metadata balancing support, and builds on the second round of patches already submitted. It adds the infrastructure to set a bit inside the mda header on a per-PV basis, control it from pvchange, display the number of mdas with this bit set on a particular PV or VG, and adds VG 'min' / 'max' parameters to control the per-PV bits.

Changes from the second round include:
1) Define the vg-level parameters which control metadata balancing:
a) vg_mda_balance_max: a number indicating the maximum number of PVs to contain enabled metadata areas; range is vg_mda_balance_min:# of PVs in VG
b) vg_mda_balance_min: a number indicating the minimum number of PVs to contain enabled metadata areas; range 1:vg_mda_balance_max
2) Add metadata_balance_{min|max} to struct volume_group, and store these parameters on disk in vg metadata.
3) Update vgchange to take metadatabalance{min|max} parameters.
4) Various small bugs fixed in the second round of patches.

Still TODO:
1) Implement the disable of mdas properly by disabling certain metadata_area_ops functions. I began this work, then ran into some lvmcache issues that need to be resolved. Code is isolated to one patch (not included in this set).
2) Implement the setting of the disable bit on various PVs when the metadatabalance{min|max} parameters are given to vgchange. Should be fairly straightforward - setting a lower 'max' value might cause metadata disable bits set on PVs, and setting a higher 'min' value may cause metadata disable bits cleared on PVs.
3) Consider renaming the 'disable' to 'enable' as this is more consistent with the 'min' and 'max' parameters