qcow2: Rewrite alloc_refcount_block
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest3 patches 3 repliesIn review
- v13 patches 8 repliesSuperseded
Changes in v2 from the cover letter
Addresses Juan's review comments:
- Simplified next_refcount_table_size
- Fixed alloc_refcount_block
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | qcow2: Factor next_refcount_table_size outblock/ | +19 | 1 reply | |
| 2/3 | qcow2: Rewrite alloc_refcount_block/grow_refcount_tableblock/ | +222 | 1 reply | |
| 3/3 | qcow2: More checks for qemu-img checkblock/ | +12 | 1 reply |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Juan Quintela |
|---|---|
| 1/3 | A-b |
| 2/3 | A-b |
| 3/3 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v2 0/3] qcow2: Rewrite alloc_refcount_block
The current implementation of alloc_refcount_block and grow_refcount_table has fundamental problems regarding error handling. There are some places where an I/O error means that the image is going to be corrupted. I have found that the only way to fix this is to completely rewrite the thing.
v2:
Addresses Juan's review comments:
- Simplified next_refcount_table_size
- Fixed alloc_refcount_block
Kevin Wolf (3):
qcow2: Factor next_refcount_table_size out
qcow2: Rewrite alloc_refcount_block/grow_refcount_table
qcow2: More checks for qemu-img check
block/qcow2-refcount.c | 346 ++++++++++++++++++++++++++++++++++------------- 1 files changed, 250 insertions(+), 96 deletions(-)