Skip to content

qcow2: Rewrite alloc_refcount_block

Kevin Wolf qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 3 repliesIn review
  2. v13 patches 8 repliesSuperseded

Changes in v2 from the cover letter

Addresses Juan's review comments:
- Simplified next_refcount_table_size
- Fixed alloc_refcount_block

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3qcow2: Factor next_refcount_table_size outblock/qcow2-refcount.c+19 -111 reply
2/3qcow2: Rewrite alloc_refcount_block/grow_refcount_tableblock/qcow2-refcount.c+222 -881 reply
3/3qcow2: More checks for qemu-img checkblock/qcow2-refcount.c+12 -01 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchJuan Quintela
1/3A-b
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/3] qcow2: Rewrite alloc_refcount_block

The current implementation of alloc_refcount_block and grow_refcount_table has fundamental problems regarding error handling. There are some places where an I/O error means that the image is going to be corrupted. I have found that the only way to fix this is to completely rewrite the thing.

v2:
Addresses Juan's review comments:
- Simplified next_refcount_table_size
- Fixed alloc_refcount_block

Kevin Wolf (3):
qcow2: Factor next_refcount_table_size out
qcow2: Rewrite alloc_refcount_block/grow_refcount_table
qcow2: More checks for qemu-img check

 block/qcow2-refcount.c |  346 ++++++++++++++++++++++++++++++++++-------------
 1 files changed, 250 insertions(+), 96 deletions(-)