Skip to content

Add vg/lv tag addition/deletion to lvm2app, v2

Dave Wysochanski lvm-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8Refactor _vgchange_tag() to vg_change_tag() library function.lib/metadata/metadata-exported.h lib/metadata/metadata.c tools/vgchange.c+27 -170 replies
2/8Refactor vgcreate to call new vg_change_tag() function.tools/vgcreate.c+2 -100 replies
3/8Refactor lvchange_tag() to call lv_change_tag() library function.lib/metadata/metadata-exported.h lib/metadata/metadata.c tools/lvchange.c+28 -190 replies
4/8Add dm_pool_strdup to allocate memory and copy a tag in {lv|vg}_change_tag()lib/metadata/metadata.c+12 -21 reply
4/8Add dm_pool_strdup to allocate memory and copy a tag in {lv|vg}_change_tag()+0 -00 replies
5/8Add tag_list_copy() supporting function inside lvm2app.liblvm/Makefile.in liblvm/lvm_misc.c liblvm/lvm_misc.h+73 -00 replies
6/8Add lvm_vg_get_tags(), lvm_vg_add_tag(), and lvm_vg_remove_tag().liblvm/.exported_symbols liblvm/lvm2app.h liblvm/lvm_vg.c+86 -22 replies
6/8Add lvm_vg_get_tags(), lvm_vg_add_tag(), and lvm_vg_remove_tag().+0 -00 replies
7/8Add lvm_lv_get_tags(), lvm_lv_add_tag(), and lvm_lv_remove_tag().liblvm/.exported_symbols liblvm/lvm2app.h liblvm/lvm_lv.c+86 -00 replies
8/8Update lvm2app interactive unit test for vg/lv tags.test/api/test.c+102 -65 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/8] Add vg/lv tag addition/deletion to lvm2app, v2

This is a second iteration of the lv/vg tag add/delete to lvm2app. pv tags will be handled later when the pv refactoring patches are done since they need the pv->vg link for the vgmem handle. Partially fixes rhbz 562909.

Changes since last set:
1) Address all feedback; change return of 'get' fns to NULL if problem obtaining list, empty list if no tags; use dm_pool_strdup, return_0, etc
2) Patch #5, Add tag_list_copy() supporting function; re-use code that duplicates the tag list