Skip to content

Clean up code to use native kernel functions when convert or check hex digits

Andy Shevchenko lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12isdn: remove ishexdigit() in regard to isxdigit()drivers/isdn/gigaset/capi.c+1 -151 reply
2/12audit: use kernel's method to get byte in hex formkernel/audit.c+3 -52 replies
3/12staging: remove unused methodsdrivers/staging/otus/apdbg.c+0 -251 reply
4/12scsi: ibmmca: use kernel native convertordrivers/scsi/ibmmca.c+1 -20 replies
5/12lib: introduce common method to convert hex digitsinclude/linux/kernel.h lib/hexdump.c+21 -00 replies
6/12drivers: net: optimize hex2bin()drivers/net/ps3_gelic_wireless.c+4 -80 replies
7/12usb: atm: speedtch: use new hex_to_bin() methoddrivers/usb/atm/speedtch.c+2 -30 replies
8/12net: use new hex_to_bin() methoddrivers/net/sb1250-mac.c+2 -300 replies
9/12drivers: net: use kernel's method to get byte in hex formdrivers/net/ppp_synctty.c+1 -30 replies
10/12drivers: net: use new hex_to_bin() methoddrivers/net/cxgb3/t3_hw.c+4 -120 replies
11/12drivers: isdn: use new hex_to_bin() methoddrivers/isdn/gigaset/capi.c+2 -122 replies
12/12drivers: wireless: use kernel's method to get byte in hex formdrivers/net/wireless/at76c50x-usb.c+1 -40 replies

Reviews trailers per patch

2 of 12 patches have a Reviewed-by or Acked-by.

PatchTilman SchmidtGreg Kroah-Hartman
1/12A-b
2/12
3/12A-b
4/12
5/12
6/12
7/12
8/12
9/12
10/12
11/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/12] Clean up code to use native kernel functions when convert or check hex digits

From: Andy Shevchenko <[email protected]>

Hello.

There are set of paches related to hex2bin, bin2hex, isxdigit custom implementations. All of them are changed by native kernel functions. In case of hex2bin there is generalized method [hex_to_bin] to do such thing which is put under lib/hexxdump.c (kernel.h).

TODO: apply hex_to_bin() to kgdb code.

Andy Shevchenko (12):
isdn: remove ishexdigit() in regard to isxdigit()
audit: use kernel's method to get byte in hex form
staging: remove unused methods
scsi: ibmmca: use kernel native convertor
lib: introduce common method to convert hex digits
drivers: net: optimize hex2bin()
usb: atm: speedtch: use new hex_to_bin() method
net: use new hex_to_bin() method
drivers: net: use kernel's method to get byte in hex form
drivers: net: use new hex_to_bin() method
drivers: isdn: use new hex_to_bin() method
drivers: wireless: use kernel's method to get byte in hex form

 drivers/isdn/gigaset/capi.c         |   30 +++---------------------------
 drivers/net/cxgb3/t3_hw.c           |   16 ++++------------
 drivers/net/ppp_synctty.c           |    4 +---
 drivers/net/ps3_gelic_wireless.c    |   12 ++++--------
 drivers/net/sb1250-mac.c            |   32 ++------------------------------
 drivers/net/wireless/at76c50x-usb.c |    5 +----
 drivers/scsi/ibmmca.c               |    3 +--
 drivers/staging/otus/apdbg.c        |   25 -------------------------
 drivers/usb/atm/speedtch.c          |    5 ++---
 include/linux/kernel.h              |    2 ++
 kernel/audit.c                      |    8 +++-----
 lib/hexdump.c                       |   19 +++++++++++++++++++
 12 files changed, 42 insertions(+), 119 deletions(-)