Skip to content

Fix some mmu/emulator atomicity issues (v2)

Avi Kivity kvm 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 3 repliesIn review

v2 from the cover letter

- fix truncated description for patch 1
- add new patch 4, which fixes a bug in patch 5

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5KVM: MMU: Consolidate two guest pte reads in kvm_mmu_pte_write()arch/x86/kvm/mmu.c+31 -380 replies
2/5KVM: Make locked operations truly atomicarch/x86/kvm/x86.c+48 -210 replies
3/5KVM: Don't follow an atomic operation by a non-atomic onearch/x86/kvm/x86.c+25 -70 replies
4/5KVM: MMU: Do not instantiate nontrapping spte on unsync pagearch/x86/kvm/paging_tmpl.h+8 -20 replies
5/5KVM: MMU: Reinstate pte prefetch on invlpgarch/x86/include/asm/kvm_host.h arch/x86/kvm/mmu.c arch/x86/kvm/paging_tmpl.h+39 -140 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] Fix some mmu/emulator atomicity issues (v2)

Currently when we emulate a locked operation into a shadowed guest page table, we perform a write rather than a true atomic. This is indicated by the "emulating exchange as write" message that shows up in dmesg.

In addition, the pte prefetch operation during invlpg suffered from a race. This was fixed by removing the operation.

This patchset fixes both issues and reinstates pte prefetch on invlpg.

v2:
- fix truncated description for patch 1
- add new patch 4, which fixes a bug in patch 5

Avi Kivity (5):
KVM: MMU: Consolidate two guest pte reads in kvm_mmu_pte_write()
KVM: Make locked operations truly atomic
KVM: Don't follow an atomic operation by a non-atomic one
KVM: MMU: Do not instantiate nontrapping spte on unsync page
KVM: MMU: Reinstate pte prefetch on invlpg

 arch/x86/include/asm/kvm_host.h |    1 +
 arch/x86/kvm/mmu.c              |   78 +++++++++++++++---------------
 arch/x86/kvm/paging_tmpl.h      |   25 +++++++++-
 arch/x86/kvm/x86.c              |  101 ++++++++++++++++++++++++++++-----------
 4 files changed, 137 insertions(+), 68 deletions(-)