Skip to content

Log and transaction cleanups, factoring and bug fixes V2

Dave Chinner linux-xfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9xfs: factor log item initialisationfs/xfs/quota/xfs_dquot_item.c fs/xfs/xfs_buf_item.c fs/xfs/xfs_extfree_item.c +3 more+29 -300 replies
2/9xfs: Add inode pin counts to tracesfs/xfs/linux-2.6/xfs_trace.h fs/xfs/xfs_inode.c fs/xfs/xfs_inode_item.c+12 -10 replies
3/9xfs: remove stale parameter from ->iop_unpin methodfs/xfs/quota/xfs_dquot_item.c fs/xfs/xfs_buf_item.c fs/xfs/xfs_extfree_item.c +4 more+39 -520 replies
4/9xfs: fix reservation release commit flag in xfs_bmap_add_attrfork()fs/xfs/xfs_bmap.c+1 -10 replies
5/9xfs: split out iclog writing from xfs_trans_commit()fs/xfs/xfs_trans.c+199 -1880 replies
6/9xfs: clean up xfs_trans_commit logic even morefs/xfs/xfs_trans.c+37 -320 replies
7/9xfs: update and factor xfs_trans_committed()fs/xfs/xfs_trans.c+95 -1290 replies
8/9xfs: Clean up xfs_trans_committed code after factoringfs/xfs/xfs_trans.c+166 -1901 reply
9/9xfs: log ticket reservation underestimates the number of iclogsfs/xfs/xfs_log.c+42 -133 replies

Reviews trailers per patch

8 of 9 patches have a Reviewed-by or Acked-by.

PatchChristoph HellwigDave Chinner
1/9R-b
2/9R-b
3/9R-b
4/9R-b
5/9R-b
6/9R-b
7/9R-b
8/9R-b
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/9] Log and transaction cleanups, factoring and bug fixes V2

The following series is preparation for delayed logging patches. The cleanups and factoring patches are mainly to make it simple to introduce the delayed logging patches, especially as these changes really have nothing to do with delayed logging. The cleanups and factoring patches should be no-ops from a functionality point of view.

A couple of the patches are fixes for bugs that I've found as I've been working through delayed logging prototypes.

Patches 8 (reservation bug fix) and 9 (new cleanup) of the series still require review.

Version 2:
- drop log vector changes from the series
- fix bogus assert in xfs_trans_committed() changes
- Added Christoph's _xfs_trans_commit() cleanup patch
- Added further cleanup of the xfs_trans_committed() code as suggested by Christoph.

These changes are also available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/dgc/xfs.git trans-cleanup

Christoph Hellwig (1):
xfs: clean up xfs_trans_commit logic even more

Dave Chinner (8):
xfs: factor log item initialisation
xfs: Add inode pin counts to traces
xfs: remove stale parameter from ->iop_unpin method
xfs: fix reservation release commit flag in xfs_bmap_add_attrfork()
xfs: split out iclog writing from xfs_trans_commit()
xfs: update and factor xfs_trans_committed()
xfs: Clean up xfs_trans_committed code after factoring
xfs: log ticket reservation underestimates the number of iclogs

 fs/xfs/linux-2.6/xfs_trace.h  |    9 +-
 fs/xfs/quota/xfs_dquot_item.c |   28 +-
 fs/xfs/xfs_bmap.c             |    2 +-
 fs/xfs/xfs_buf_item.c         |   55 ++--
 fs/xfs/xfs_extfree_item.c     |   18 +-
 fs/xfs/xfs_inode.c            |    2 +
 fs/xfs/xfs_inode_item.c       |   21 +-
 fs/xfs/xfs_log.c              |   68 +++-
 fs/xfs/xfs_log.h              |    7 +
 fs/xfs/xfs_trans.c            |  760 +++++++++++++++++++----------------------
 fs/xfs/xfs_trans.h            |    5 +-
 fs/xfs/xfs_trans_buf.c        |    3 +-
 12 files changed, 481 insertions(+), 497 deletions(-)

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs