RFC blkdebug
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest7 patches 11 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | qemu-config: qemu_read_config_file() reads the normal config fileqemu-config.c qemu-config.h vl.c | +30 | 1 reply | |
| 2/7 | qemu-config: Make qemu_config_parse more genericqemu-config.c qemu-config.h | +9 | 1 reply | |
| 3/7 | blkdebug: Basic request passthroughMakefile.objs block/ | +105 | 1 reply | |
| 4/7 | blkdebug: Inject errorsblock/ | +63 | 1 reply | |
| 5/7 | Make qemu-config available for toolsMakefile.objs hw/ hw/ +1 more | +20 | 1 reply | |
| 6/7 | blkdebug: Add events and rulesblock.c block.h block/ +1 more | +264 | 2 replies | |
| 7/7 | qcow2: Trigger blkdebug eventsblock.h block/ block/ | +51 | 1 reply |
Reviews trailers per patch
6 of 7 patches have a Reviewed-by or Acked-by.
| Patch | Christoph Hellwig |
|---|---|
| 1/7 | R-b |
| 2/7 | R-b |
| 3/7 | R-b |
| 4/7 | R-b |
| 5/7 | R-b |
| 6/7 | |
| 7/7 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [RFC][PATCH 0/7] blkdebug
This patch series introduces a new block driver which acts as a protocol and whose purpose it is to fail requests. To be more precise, I want it to fail in configurable places, so that qemu-iotests can be extended with tests for the error paths (for example for the case when something with metadata writes goes wrong deep in qcow2).
It works like this (I think this is self-explanatory):
$ cat /tmp/blkdebug.cfg [inject-error] event = "l1_update" errno = "5" immediately = "on" $ qemu-io blkdebug:/tmp/blkdebug.cfg:/tmp/empty.qcow2 qemu-io> read 0 4k read 4096/4096 bytes at offset 0 4 KiB, 1 ops; 0.0000 sec (195.312 MiB/sec and 50000.0000 ops/sec) qemu-io> write 0 4k bdrv_debug_event: 4 blkdebug_debug_event: 4 write failed: Input/output error
Basically what I think is left to do is:
- Resolve TODOs and FIXMEs left in the code
- Require blkdebug to be explicitly enabled before compiling in event generation (not sure if it really matters)
- Add more events, they are only added for qcow2-clusters so far
- Address your comments (if any)
Kevin Wolf (7):
qemu-config: qemu_read_config_file() reads the normal config file
qemu-config: Make qemu_config_parse more generic
blkdebug: Basic request passthrough
blkdebug: Inject errors
Make qemu-config available for tools
blkdebug: Add events and rules
qcow2: Trigger blkdebug events
Makefile.objs | 6 +- block.c | 13 ++ block.h | 28 ++++ block/blkdebug.c | 423 +++++++++++++++++++++++++++++++++++++++++++++++++ block/qcow2-cluster.c | 15 ++ block_int.h | 2 + hw/qdev-properties.c | 19 ++- hw/qdev.h | 1 - qemu-config.c | 45 +++--- qemu-config.h | 4 +- vl.c | 34 ++--- 11 files changed, 540 insertions(+), 50 deletions(-) create mode 100644 block/blkdebug.c