Skip to content

Kill the bkl in procfs

Frederic Weisbecker lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 39 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6procfs: Kill BKL in llseek on proc basefs/proc/base.c+9 -12 replies
2/6procfs: Use generic_file_llseek in /proc/kcorefs/proc/kcore.c+1 -01 reply
3/6procfs: Use generic_file_llseek in /proc/kmsgfs/proc/kmsg.c+1 -01 reply
4/6procfs: Use generic_file_llseek in /proc/vmcorefs/proc/vmcore.c+1 -01 reply
5/6procfs: Push down the bkl from ioctldrivers/char/i8k.c drivers/isdn/divert/divert_procfs.c net/sunrpc/cache.c+109 -549 replies
6/6procfs: Kill the bkl in ioctlfs/proc/inode.c+2 -227 replies

Reviews trailers per patch

4 of 6 patches have a Reviewed-by or Acked-by.

PatchArnd Bergmann
1/6
2/6A-b
3/6A-b
4/6A-b
5/6A-b A-b A-b A-b
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/6] Kill the bkl in procfs

Hi,

This patchset drops any use of the big kernel lock from procfs. May be there is still one or two NULL llseek somewhere but I think we have fixed 99% of those that were in the procfs core.

Users of procfs implementing an ioctl have not been easy to spot automatically (there are hundreds of procfs users) as there are many indirect ways to register a procfs, depending on the subsystem you are.

So for those who want to verify the reliability of this check, you can look at the script there:

http://tglx.de/~fweisbec/seek.py

Beware it's very dirty! The hardcoded path are those I had to check manually (or that I added to the automatic check). One day I should learn how to use Coccinelle instead.

In the worst case, the remaining ones this script or my eyes forgot will trigger a warning.

Thanks.

Arnd Bergmann (1):
procfs: Kill BKL in llseek on proc base

Frederic Weisbecker (5):
procfs: Use generic_file_llseek in /proc/kcore
procfs: Use generic_file_llseek in /proc/kmsg
procfs: Use generic_file_llseek in /proc/vmcore
procfs: Push down the bkl from ioctl
procfs: Kill the bkl in ioctl

 drivers/char/i8k.c                  |   53 +++++++++++++++------
 drivers/isdn/divert/divert_procfs.c |   90 ++++++++++++++++++++++-------------
 fs/proc/base.c                      |   10 ++++-
 fs/proc/inode.c                     |    4 +-
 fs/proc/kcore.c                     |    1 +
 fs/proc/kmsg.c                      |    1 +
 fs/proc/vmcore.c                    |    1 +
 net/sunrpc/cache.c                  |   20 ++++++--
 8 files changed, 123 insertions(+), 57 deletions(-)