Skip to content

xfs: bug fixes, cleanups and tracing

Dave Chinner linux-xfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 of 8 patches 12 repliesIn review

7 of 8 patches are in this archive. The cover letter announces 8.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
2/8xfs: don't warn on EAGAIN in inode reclaimfs/xfs/linux-2.6/xfs_sync.c+2 -21 reply
3/8xfs: make the log ticket transaction id randomfs/xfs/xfs_log.c+1 -13 replies
4/8xfs: add log item recovery tracingfs/xfs/linux-2.6/xfs_trace.c fs/xfs/linux-2.6/xfs_trace.h fs/xfs/xfs_buf_item.h +1 more+187 -92 replies
5/8xfs: convert the per-mount dquot list to use list headsfs/xfs/quota/xfs_dquot.c fs/xfs/quota/xfs_dquot.h fs/xfs/quota/xfs_qm.c +3 more+97 -1121 reply
6/8xfs: remove duplicate code from dquot reclaimfs/xfs/linux-2.6/xfs_trace.h fs/xfs/quota/xfs_qm.c+78 -1931 reply
7/8xfs: convert the dquot hash list to use list headsfs/xfs/linux-2.6/xfs_trace.h fs/xfs/quota/xfs_dquot.c fs/xfs/quota/xfs_dquot.h +3 more+30 -881 reply
8/8xfs: convert the dquot free list to use list headsfs/xfs/quota/xfs_dquot.c fs/xfs/quota/xfs_dquot.h fs/xfs/quota/xfs_qm.c +3 more+72 -1651 reply

Reviews trailers per patch

5 of 7 patches have a Reviewed-by or Acked-by.

PatchAlex ElderChristoph Hellwig
2/8R-b R-b
3/8
4/8
5/8R-b
6/8R-b
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/8] xfs: bug fixes, cleanups and tracing

The first two patches are reposts of reviewed patches not yet in the dev tree. Christoph, the sync fix has been cleaned up like you suggested, you might want to pass an eye over it again.

The next two are log changes - the first is making the transaction ID that identifies transactions on disk really unique. The second is a bunch of tracing additions to log recovery that I wrote recently to track down an issue with delayed logging causing corruptions during recovery.

The last four are the start of cleaning up some of the dquot code. They basicaly remove all the hand coded linked list operations and obfuscated locking macros for all the lists that the dquots can exist on. One patch also removes a duplicated reclaim algorithm and uses the common function to implement both reclaim and shaking of dquots. I haven't done a huge amount of testing on these yet, but they've passed several runs of xfsqa on both single and quad processor VMs so far.

As usual, the series can also be found in my git tree...

The following changes since commit 68a2ac777cca40ccc993512bcf457999be71cc36:
Christoph Hellwig (1):
xfs: clean up xlog_write_adv_cnt

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/dgc/xfs.git working

Dave Chinner (8):
xfs: ensure that sync updates the log tail correctly
xfs: don't warn on EAGAIN in inode reclaim
xfs: make the log ticket transaction id random
xfs: add log item recovery tracing
xfs: convert the per-mount dquot list to use list heads
xfs: remove duplicate code from dquot reclaim
xfs: convert the dquot hash list to use list heads
xfs: convert the dquot free list to use list heads

 fs/xfs/linux-2.6/xfs_sync.c    |    4 +-
 fs/xfs/linux-2.6/xfs_trace.c   |    3 +
 fs/xfs/linux-2.6/xfs_trace.h   |  150 +++++++++++-
 fs/xfs/quota/xfs_dquot.c       |  120 ++++------
 fs/xfs/quota/xfs_dquot.h       |   14 +-
 fs/xfs/quota/xfs_qm.c          |  520 ++++++++++++++--------------------------
 fs/xfs/quota/xfs_qm.h          |   23 +--
 fs/xfs/quota/xfs_qm_stats.c    |    2 +-
 fs/xfs/quota/xfs_qm_syscalls.c |   36 +--
 fs/xfs/quota/xfs_quota_priv.h  |   75 ------
 fs/xfs/xfs_buf_item.h          |    2 +-
 fs/xfs/xfs_log.c               |   40 ++-
 fs/xfs/xfs_log_recover.c       |   44 +++-
 13 files changed, 472 insertions(+), 561 deletions(-)

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs