Skip to content

DSPBRIDGE: generic clk module removal

Omar Ramirez Luna linux-omap 3 versions – Applied

Status from this message: Pushed to dspbridge.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/219 patches 1 replyApplied
  2. v2 posting 1/21 patch 2 repliesSuperseded
  3. v119 patches 0 repliesSuperseded

Changes in v2 from the cover letter

- rebased
- keep iva2 handling as it is advised to turn off the clocks for iva reset sources.
- release all the clocks (disable & free) if driver is uninstalled.

Patches in v2 posting 2/2 Applied

#Subject and filesSizeRepliesApplied
1/19DSPBRIDGE: remove clk_handle from drv interfacedrivers/dsp/bridge/rmgr/drv_interface.c+0 -90 replies
2/19DSPBRIDGE: fail if clk handle is NULLdrivers/dsp/bridge/services/clk.c+20 -480 replies
3/19DSPBRIDGE: Now actually fail if a clk handle is wrongdrivers/dsp/bridge/services/clk.c+1 -10 replies
4/19DSPBRIDGE: Rename services_clk_* to dsp_clk_*arch/arm/plat-omap/include/dspbridge/clk.h drivers/dsp/bridge/services/clk.c drivers/dsp/bridge/services/services.c +3 more+112 -1120 replies
5/19DSPBRIDGE: remove unused clock sys_ckarch/arm/plat-omap/include/dspbridge/clk.h drivers/dsp/bridge/services/clk.c+0 -20 replies
6/19DSPBRIDGE: remove function clk_set32k_hzarch/arm/plat-omap/include/dspbridge/clk.h drivers/dsp/bridge/services/clk.c drivers/dsp/bridge/wmd/tiomap3430.c+1 -540 replies
7/19DSPBRIDGE: remove clk_get_use_cntarch/arm/plat-omap/include/dspbridge/clk.h drivers/dsp/bridge/services/clk.c+0 -360 replies
8/19DSPBRIDGE: trivial clock cleanup for unused codearch/arm/plat-omap/include/dspbridge/clk.h drivers/dsp/bridge/services/clk.c+0 -90 replies
9/19DSPBRIDGE: function to get the type of clock requested by dspdrivers/dsp/bridge/services/clk.c+68 -210 replies
10/19DSPBRIDGE: iva2 clock handlingarch/arm/plat-omap/include/dspbridge/clk.h drivers/dsp/bridge/services/clk.c drivers/dsp/bridge/services/services.c +1 more+22 -770 replies
11/19DSPBRIDGE: use dm timer framework for gpt timersdrivers/dsp/bridge/services/clk.c drivers/dsp/bridge/wmd/tiomap3430.c+13 -480 replies
12/19DSPBRIDGE: use omap mcbsp to enable mcbsp clocksdrivers/dsp/bridge/services/clk.c+10 -140 replies
13/19DSPBRIDGE: remove wdt3 from dsp controldrivers/dsp/bridge/services/clk.c+4 -20 replies
14/19DSPBRIDGE: dsp interface to enable ssi clocksdrivers/dsp/bridge/services/clk.c+27 -290 replies
15/19DSPBRIDGE: use one call for both ick and fck clocksarch/arm/plat-omap/include/dspbridge/clk.h drivers/dsp/bridge/services/clk.c drivers/dsp/bridge/wmd/_tiomap.h +2 more+45 -720 replies
16/19DSPBRIDGE: Move MCBSP_CLOCKS code to a common placedrivers/dsp/bridge/services/clk.c drivers/dsp/bridge/wmd/tiomap3430_pwr.c+52 -770 replies
17/19DSPBRIDGE: Balance the number of enable/disabledrivers/dsp/bridge/services/clk.c+37 -00 replies
18/19DSPBRIDGE: move clk to dsp-clockdrivers/dsp/bridge/Makefile drivers/dsp/bridge/rmgr/drv_interface.c drivers/dsp/bridge/services/clk.c +2 more+338 -3390 replies
19/19DSPBRIDGE: reorganize the code to handle peripheral clocksarch/arm/plat-omap/include/dspbridge/clk.h drivers/dsp/bridge/rmgr/drv_interface.c drivers/dsp/bridge/wmd/_tiomap_pwr.h +4 more+56 -620 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/19] DSPBRIDGE: generic clk module removal

This set of patches remove clk module from the services layer.

Now:
- GPT 5-8 are controlled through DM Timer framework.
- MCBSP clocks are enabled by requesting the proper mcbsp device.
- WDT is left for bridge driver to control rather than on request from dsp.
- SSI is controlled by enabling/disabling its sst, ssr and ick clocks.

v2:
- rebased
- keep iva2 handling as it is advised to turn off the clocks for iva reset sources.
- release all the clocks (disable & free) if driver is uninstalled.

Omar Ramirez Luna (19):
DSPBRIDGE: remove clk_handle from drv interface
DSPBRIDGE: fail if clk handle is NULL
DSPBRIDGE: Now actually fail if a clk handle is wrong
DSPBRIDGE: Rename services_clk_* to dsp_clk_*
DSPBRIDGE: remove unused clock sys_ck
DSPBRIDGE: remove function clk_set32k_hz
DSPBRIDGE: remove clk_get_use_cnt
DSPBRIDGE: trivial clock cleanup for unused code
DSPBRIDGE: function to get the type of clock requested by dsp
DSPBRIDGE: iva2 clock handling
DSPBRIDGE: use dm timer framework for gpt timers
DSPBRIDGE: use omap mcbsp to enable mcbsp clocks
DSPBRIDGE: remove wdt3 from dsp control
DSPBRIDGE: dsp interface to enable ssi clocks
DSPBRIDGE: use one call for both ick and fck clocks
DSPBRIDGE: Move MCBSP_CLOCKS code to a common place
DSPBRIDGE: Balance the number of enable/disable
DSPBRIDGE: move clk to dsp-clock
DSPBRIDGE: reorganize the code to handle peripheral clocks

 arch/arm/plat-omap/include/dspbridge/clk.h |  103 ++------
 drivers/dsp/bridge/Makefile                |    4 +-
 drivers/dsp/bridge/rmgr/drv_interface.c    |   12 +-
 drivers/dsp/bridge/services/clk.c          |  323 ------------------------
 drivers/dsp/bridge/services/services.c     |   10 +-
 drivers/dsp/bridge/wmd/_tiomap.h           |   25 +-
 drivers/dsp/bridge/wmd/_tiomap_pwr.h       |   17 --
 drivers/dsp/bridge/wmd/dsp-clock.c         |  377 ++++++++++++++++++++++++++++
 drivers/dsp/bridge/wmd/tiomap3430.c        |   62 +-----
 drivers/dsp/bridge/wmd/tiomap3430_pwr.c    |  147 +----------
 drivers/dsp/bridge/wmd/tiomap_io.c         |    4 +-
 drivers/dsp/bridge/wmd/ue_deh.c            |    2 +-
 12 files changed, 440 insertions(+), 646 deletions(-)
 delete mode 100644 drivers/dsp/bridge/services/clk.c
 create mode 100644 drivers/dsp/bridge/wmd/dsp-clock.c