Skip to content

AMD L3 cache index disable fixes for .35

Borislav Petkov lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5x86, cacheinfo: Unify AMD L3 cache index disable checkingarch/x86/kernel/cpu/intel_cacheinfo.c+10 -70 replies
2/5x86, cacheinfo: Turn off L3 cache index disable feature in virtualized environmentsarch/x86/kernel/cpu/intel_cacheinfo.c+4 -00 replies
3/5x86, cacheinfo: Reorganize AMD L3 cache structurearch/x86/kernel/cpu/intel_cacheinfo.c+32 -210 replies
4/5x86, cacheinfo: Make L3 cache info per nodearch/x86/kernel/cpu/intel_cacheinfo.c+35 -142 replies
5/5x86, cacheinfo: Disable index in all four subcachesarch/x86/kernel/cpu/intel_cacheinfo.c+43 -170 replies

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchBorislav Petkov
1/5
2/5A-b
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] AMD L3 cache index disable fixes for .35

From: Borislav Petkov <[email protected]>

Hi,

this is a small patchset of fixes for L3 CID which have accumulated over the last couple of weeks. They serve as a preparation for disabling L3 cache indices whenever an L3 MCE triggers, has been evaluated and the offending index thresholded and, if error rate is excessively high, disabled. Those patches will be coming up later though.

Patches 1,3,4 are cleanups and unifications which save us a little bit of percpu memory in favor of dynamic allocation. Also, we have an L3 cache descriptor per node now instead of having this information per CPU.

I triggered a lockdep warning in lockdep_trace_alloc() during testing due to the fact that we may run with disabled interrupts that early in the boot process. Therefore, I have a GFP_ATOMIC in patch 3 there allocating the cache descriptors. I'm open for suggestions in case this is undesired.

Patch 2 is a fix which triggers when we run as a guest on Xen due to Xen not exporting CPU PCI config space to the guests.

And finally #5 is a required fix.

The patchset is also available at
git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git l3-for-35

Please queue for .35,
thanks.