rt2x00: Further fixes and cleanups.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest10 patches 4 repliesIn review
- v19 patches 22 repliesSuperseded
Changes in v2 from the cover letter
- Handled Ivo's feedback.
- Added a new patch to the series (as part of Ivo's feedback handling) on moving declaration of rt2x00debug_dump_frame to rt2x00.h.
- Reordered the patches to have the small preparatory patches in the beginning of the series, and the real functional patches towards the end.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | rt2x00: Consistently name skb frame descriptor skbdesc.drivers/ | +7 | 0 replies | |
| 2/10 | rt2x00: In debugfs frame dumping allow the TX descriptor to be part of the skb.drivers/ drivers/ | +13 | 0 replies | |
| 3/10 | rt2x00: Dump beacons under a different identifier than TX frames.drivers/ drivers/ | +7 | 0 replies | |
| 4/10 | rt2x00: Move rt2x00debug_dump_frame declaration to rt2x00.h.drivers/ drivers/ drivers/ +1 more | +36 | 2 replies | |
| 5/10 | rt2x00: Fix beacon descriptor writing for rt61pci.drivers/ | +5 | 0 replies | |
| 6/10 | rt2x00: Re-order tx descriptor writing code in drivers.drivers/ drivers/ drivers/ +2 more | +59 | 0 replies | |
| 7/10 | rt2x00: Simplify TXD handling of beacons.drivers/ drivers/ drivers/ +7 more | +72 | 0 replies | |
| 8/10 | rt2x00: Push beacon TX descriptor writing to drivers.drivers/ drivers/ drivers/ +5 more | +81 | 1 reply | |
| 9/10 | rt2x00: Reverse calling order of bus write_tx_desc and driver write_tx_desc.drivers/ drivers/ drivers/ +1 more | +18 | 1 reply | |
| 10/10 | rt2x00: Properly reserve room for descriptors in skbs.drivers/ drivers/ drivers/ +13 more | +109 | 0 replies |
Reviews trailers per patch
9 of 10 patches have a Reviewed-by or Acked-by.
| Patch | Ivo van Doorn |
|---|---|
| 1/10 | A-b |
| 2/10 | A-b |
| 3/10 | A-b |
| 4/10 | |
| 5/10 | A-b |
| 6/10 | A-b |
| 7/10 | A-b |
| 8/10 | A-b |
| 9/10 | A-b |
| 10/10 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 00/10] rt2x00: Further fixes and cleanups.
Another set of rt2x00 fixes and cleanups.
Most of the patches are working towards a nice cleanup in which rt2x00 starts properly reserving room in skbs for descriptors instead of fiddling with pointers.
Also one fix for rt61pci that no-one ever hit, whereby, for beacons, rt61pci wrote part of the tx descriptor out-of-bounds.
These patches can also be pulled from:
git://git.gwingerde.nl/rt2x00-next-2.6.git
v2:
- Handled Ivo's feedback.
- Added a new patch to the series (as part of Ivo's feedback handling) on moving declaration of rt2x00debug_dump_frame to rt2x00.h.
- Reordered the patches to have the small preparatory patches in the beginning of the series, and the real functional patches towards the end.
Gertjan van Wingerde (10):
rt2x00: Consistently name skb frame descriptor skbdesc.
rt2x00: In debugfs frame dumping allow the TX descriptor to be part of the skb.
rt2x00: Dump beacons under a different identifier than TX frames.
rt2x00: Move rt2x00debug_dump_frame declaration to rt2x00.h.
rt2x00: Fix beacon descriptor writing for rt61pci.
rt2x00: Re-order tx descriptor writing code in drivers.
rt2x00: Simplify TXD handling of beacons.
rt2x00: Push beacon TX descriptor writing to drivers.
rt2x00: Reverse calling order of bus write_tx_desc and driver write_tx_desc.
rt2x00: Properly reserve room for descriptors in skbs.
drivers/net/wireless/rt2x00/rt2400pci.c | 41 ++++++++------ drivers/net/wireless/rt2x00/rt2500pci.c | 41 ++++++++------ drivers/net/wireless/rt2x00/rt2500usb.c | 67 ++++++++++++++--------- drivers/net/wireless/rt2x00/rt2800lib.c | 3 +- drivers/net/wireless/rt2x00/rt2800lib.h | 2 +- drivers/net/wireless/rt2x00/rt2800pci.c | 58 +++++++++++++------- drivers/net/wireless/rt2x00/rt2800usb.c | 34 ++++++++++-- drivers/net/wireless/rt2x00/rt2x00.h | 9 +++ drivers/net/wireless/rt2x00/rt2x00debug.c | 23 +++++--- drivers/net/wireless/rt2x00/rt2x00debug.h | 34 ++++++++++++ drivers/net/wireless/rt2x00/rt2x00dev.c | 5 -- drivers/net/wireless/rt2x00/rt2x00dump.h | 3 + drivers/net/wireless/rt2x00/rt2x00lib.h | 40 -------------- drivers/net/wireless/rt2x00/rt2x00pci.c | 49 +++++++++++++++-- drivers/net/wireless/rt2x00/rt2x00pci.h | 8 +++ drivers/net/wireless/rt2x00/rt2x00queue.c | 39 +------------- drivers/net/wireless/rt2x00/rt2x00queue.h | 3 + drivers/net/wireless/rt2x00/rt2x00usb.c | 19 +++---- drivers/net/wireless/rt2x00/rt61pci.c | 49 ++++++++++++----- drivers/net/wireless/rt2x00/rt73usb.c | 83 +++++++++++++++++------------ 20 files changed, 365 insertions(+), 245 deletions(-)