Skip to content

rt2x00: Further fixes and cleanups.

Gertjan van Wingerde linux-wireless 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest10 patches 4 repliesIn review
  2. v19 patches 22 repliesSuperseded

Changes in v2 from the cover letter

- Handled Ivo's feedback.
- Added a new patch to the series (as part of Ivo's feedback handling) on moving declaration of rt2x00debug_dump_frame to rt2x00.h.
- Reordered the patches to have the small preparatory patches in the beginning of the series, and the real functional patches towards the end.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10rt2x00: Consistently name skb frame descriptor skbdesc.drivers/net/wireless/rt2x00/rt2x00debug.c+7 -60 replies
2/10rt2x00: In debugfs frame dumping allow the TX descriptor to be part of the skb.drivers/net/wireless/rt2x00/rt2x00debug.c drivers/net/wireless/rt2x00/rt2x00queue.h+13 -40 replies
3/10rt2x00: Dump beacons under a different identifier than TX frames.drivers/net/wireless/rt2x00/rt2x00dump.h drivers/net/wireless/rt2x00/rt2x00queue.c+7 -10 replies
4/10rt2x00: Move rt2x00debug_dump_frame declaration to rt2x00.h.drivers/net/wireless/rt2x00/rt2x00.h drivers/net/wireless/rt2x00/rt2x00debug.c drivers/net/wireless/rt2x00/rt2x00dump.h +1 more+36 -302 replies
5/10rt2x00: Fix beacon descriptor writing for rt61pci.drivers/net/wireless/rt2x00/rt61pci.c+5 -50 replies
6/10rt2x00: Re-order tx descriptor writing code in drivers.drivers/net/wireless/rt2x00/rt2400pci.c drivers/net/wireless/rt2x00/rt2500pci.c drivers/net/wireless/rt2x00/rt2500usb.c +2 more+59 -440 replies
7/10rt2x00: Simplify TXD handling of beacons.drivers/net/wireless/rt2x00/rt2400pci.c drivers/net/wireless/rt2x00/rt2500pci.c drivers/net/wireless/rt2x00/rt2500usb.c +7 more+72 -810 replies
8/10rt2x00: Push beacon TX descriptor writing to drivers.drivers/net/wireless/rt2x00/rt2400pci.c drivers/net/wireless/rt2x00/rt2500pci.c drivers/net/wireless/rt2x00/rt2500usb.c +5 more+81 -211 reply
9/10rt2x00: Reverse calling order of bus write_tx_desc and driver write_tx_desc.drivers/net/wireless/rt2x00/rt2800pci.c drivers/net/wireless/rt2x00/rt2x00.h drivers/net/wireless/rt2x00/rt2x00pci.c +1 more+18 -111 reply
10/10rt2x00: Properly reserve room for descriptors in skbs.drivers/net/wireless/rt2x00/rt2400pci.c drivers/net/wireless/rt2x00/rt2500pci.c drivers/net/wireless/rt2x00/rt2500usb.c +13 more+109 -790 replies

Reviews trailers per patch

9 of 10 patches have a Reviewed-by or Acked-by.

PatchIvo van Doorn
1/10A-b
2/10A-b
3/10A-b
4/10
5/10A-b
6/10A-b
7/10A-b
8/10A-b
9/10A-b
10/10A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/10] rt2x00: Further fixes and cleanups.

Another set of rt2x00 fixes and cleanups.
Most of the patches are working towards a nice cleanup in which rt2x00 starts properly reserving room in skbs for descriptors instead of fiddling with pointers.
Also one fix for rt61pci that no-one ever hit, whereby, for beacons, rt61pci wrote part of the tx descriptor out-of-bounds.

These patches can also be pulled from:

	git://git.gwingerde.nl/rt2x00-next-2.6.git

v2:
- Handled Ivo's feedback.
- Added a new patch to the series (as part of Ivo's feedback handling) on moving declaration of rt2x00debug_dump_frame to rt2x00.h.
- Reordered the patches to have the small preparatory patches in the beginning of the series, and the real functional patches towards the end.

Gertjan van Wingerde (10):
rt2x00: Consistently name skb frame descriptor skbdesc.
rt2x00: In debugfs frame dumping allow the TX descriptor to be part of the skb.
rt2x00: Dump beacons under a different identifier than TX frames.
rt2x00: Move rt2x00debug_dump_frame declaration to rt2x00.h.
rt2x00: Fix beacon descriptor writing for rt61pci.
rt2x00: Re-order tx descriptor writing code in drivers.
rt2x00: Simplify TXD handling of beacons.
rt2x00: Push beacon TX descriptor writing to drivers.
rt2x00: Reverse calling order of bus write_tx_desc and driver write_tx_desc.
rt2x00: Properly reserve room for descriptors in skbs.

 drivers/net/wireless/rt2x00/rt2400pci.c   |   41 ++++++++------
 drivers/net/wireless/rt2x00/rt2500pci.c   |   41 ++++++++------
 drivers/net/wireless/rt2x00/rt2500usb.c   |   67 ++++++++++++++---------
 drivers/net/wireless/rt2x00/rt2800lib.c   |    3 +-
 drivers/net/wireless/rt2x00/rt2800lib.h   |    2 +-
 drivers/net/wireless/rt2x00/rt2800pci.c   |   58 +++++++++++++-------
 drivers/net/wireless/rt2x00/rt2800usb.c   |   34 ++++++++++--
 drivers/net/wireless/rt2x00/rt2x00.h      |    9 +++
 drivers/net/wireless/rt2x00/rt2x00debug.c |   23 +++++---
 drivers/net/wireless/rt2x00/rt2x00debug.h |   34 ++++++++++++
 drivers/net/wireless/rt2x00/rt2x00dev.c   |    5 --
 drivers/net/wireless/rt2x00/rt2x00dump.h  |    3 +
 drivers/net/wireless/rt2x00/rt2x00lib.h   |   40 --------------
 drivers/net/wireless/rt2x00/rt2x00pci.c   |   49 +++++++++++++++--
 drivers/net/wireless/rt2x00/rt2x00pci.h   |    8 +++
 drivers/net/wireless/rt2x00/rt2x00queue.c |   39 +-------------
 drivers/net/wireless/rt2x00/rt2x00queue.h |    3 +
 drivers/net/wireless/rt2x00/rt2x00usb.c   |   19 +++----
 drivers/net/wireless/rt2x00/rt61pci.c     |   49 ++++++++++++-----
 drivers/net/wireless/rt2x00/rt73usb.c     |   83 +++++++++++++++++------------
 20 files changed, 365 insertions(+), 245 deletions(-)