Skip to content

V4: rwsem changes + down_read_critical() proposal

Michel Lespinasse lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 24 repliesIn review

Changes since V3 from the cover letter

- Split first x86 rwsem change in two smaller parts
- Added David's rwsem_waiter_type enum suggestion into 'rwsem: down_read_critical infrastructure support'
- Lots of minor style fixes and comments clarified

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11x86 rwsem: stay on fast path when count>0 in __up_write()arch/x86/include/asm/rwsem.h+2 -30 replies
2/11x86 rwsem: minor cleanupsarch/x86/include/asm/rwsem.h+7 -90 replies
3/11rwsem: fully separate code pathes to wake writers vs readerslib/rwsem.c+34 -270 replies
4/11rwsem: lighter active count checks when waking up readerslib/rwsem.c+32 -251 reply
5/11rwsem: let RWSEM_WAITING_BIAS represent any number of waiting threadslib/rwsem.c+17 -110 replies
6/11rwsem: wake queued readers when writer blocks on active read locklib/rwsem.c+15 -411 replies
7/11rwsem: smaller wrappers around rwsem_down_failed_commonlib/rwsem.c+10 -150 replies
8/11generic rwsem: implement down_read_critical() / up_read_critical()include/linux/rwsem-spinlock.h include/linux/rwsem.h kernel/rwsem.c +1 more+63 -40 replies
9/11rwsem: down_read_critical infrastructure supportlib/rwsem.c+31 -90 replies
10/11x86 rwsem: down_read_critical implementationarch/x86/include/asm/rwsem.h arch/x86/lib/rwsem_64.S arch/x86/lib/semaphore_32.S+71 -160 replies
11/11Use down_read_critical() for /proc/<pid>/exe and /proc/<pid>/maps filesfs/proc/base.c fs/proc/task_mmu.c include/linux/proc_fs.h+20 -92 replies

Reviews trailers per patch

5 of 11 patches have a Reviewed-by or Acked-by.

PatchDavid Howells
1/11A-b
2/11A-b
3/11
4/11
5/11A-b
6/11
7/11A-b
8/11
9/11
10/11A-b
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/11] V4: rwsem changes + down_read_critical() proposal

This is version 4 of my rwsem changes.

Changes since V3:

- Split first x86 rwsem change in two smaller parts
- Added David's rwsem_waiter_type enum suggestion into 'rwsem: down_read_critical infrastructure support'
- Lots of minor style fixes and comments clarified

I would hope the entire series can be considered for inclusion; however if we can not agree on the down_read_critical() bits I would still like patches 1-7 to be independently considered as I think they still have merit on their own.

Michel Lespinasse (11):
x86 rwsem: stay on fast path when count>0 in __up_write() x86 rwsem: minor cleanups
rwsem: fully separate code pathes to wake writers vs readers
rwsem: lighter active count checks when waking up readers
rwsem: let RWSEM_WAITING_BIAS represent any number of waiting threads
rwsem: wake queued readers when writer blocks on active read lock
rwsem: smaller wrappers around rwsem_down_failed_common generic rwsem: implement down_read_critical() / up_read_critical()
rwsem: down_read_critical infrastructure support
x86 rwsem: down_read_critical implementation
Use down_read_critical() for /proc/<pid>/exe and /proc/<pid>/maps files

 arch/x86/include/asm/rwsem.h   |   73 +++++++++++------
 arch/x86/lib/rwsem_64.S        |   14 +++-
 arch/x86/lib/semaphore_32.S    |   21 ++++-
 fs/proc/base.c                 |    4 +-
 fs/proc/task_mmu.c             |   24 ++++--
 include/linux/proc_fs.h        |    1 +
 include/linux/rwsem-spinlock.h |   10 ++-
 include/linux/rwsem.h          |   12 +++
 kernel/rwsem.c                 |   35 ++++++++
 lib/rwsem-spinlock.c           |   10 ++-
 lib/rwsem.c                    |  178 +++++++++++++++++++++++++---------------
 11 files changed, 276 insertions(+), 106 deletions(-)