Skip to content

RFC Finer granularity and task/cgroup irq time accounting

Venkatesh Pallipadi lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest4 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4sched: Track and export per task [hard|soft]irq timeDocumentation/filesystems/proc.txt fs/proc/array.c include/linux/sched.h +2 more+31 -62 replies
2/4x86: Add IRQ_TIME_ACCOUNTING, finer accounting of irq time to taskarch/x86/Kconfig fs/proc/array.c include/linux/hardirq.h +1 more+56 -53 replies
3/4sched: Generalize cpuacct usage tracking making it simpler to add new statsinclude/linux/percpu.h kernel/sched.c kernel/sched_fair.c +1 more+32 -150 replies
4/4sched: Export irq times through cpuacct cgroupkernel/sched.c+45 -100 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/4] Finer granularity and task/cgroup irq time accounting

Currently, the softirq and hardirq time reporting is only done at the CPU level. There are usecases where reporting this time against task or task groups or cgroups will be useful for user/administrator in terms of resource planning and utilization charging. Also, as the accoounting is already done at the CPU level, reporting the same at the task level does not add any significant computational overhead other than task level storage (patch 1).

The softirq/hardirq statistics commonly done based on tick based sampling. Though some archs have CONFIG_VIRT_CPU_ACCOUNTING based fine granularity accounting. Having similar mechanism to get fine granularity accounting on x86 will be a major challenge, given the state of TSC reliability on various platforms and also the overhead it may add in common paths like syscall entry exit.

An alternative is to have a generic (sched_clock based) and configurable fine-granularity accounting of si and hi time which can be reported over the /proc/<pid>/stat API (patch 2).

Patch 3 and 4 are exporting this info at the cgroup level.

Does exposing this additional info to user makes sense? Any feedback on the way it is done in this patchset?

This precise irq time based on sched_clock() provides some potential opportunities to handle the softirq time charging in a more fair way. Specifically cases where an unrelated task is being penalized for irq load on that CPU.
* With network Receive Flow Steering, for example; We can potentially do things like not charge receive softirq time to the process that is currently running and charge it instead to the actual consumer of the receive (in recvmsg, for example).
* We can reduce the power of the CPU to account for softirq/hardirq load, in order to increase the scheduler fairness for tasks running on that CPU.

Comments?

Thanks,
Venki