Skip to content

qcow2 fixes

Kevin Wolf qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5qcow2: Allow qcow2_get_cluster_offset to return errorsblock/qcow2-cluster.c block/qcow2.c block/qcow2.h+37 -191 reply
2/5qcow2: Change l2_load to return 0/-errnoblock/qcow2-cluster.c+22 -161 reply
3/5qcow2: Return right error code in write_refcount_block_entriesblock/qcow2-refcount.c+15 -121 reply
4/5qcow2: Fix corruption after refblock allocationblock/qcow2-refcount.c+9 -21 reply
5/5qcow2: Fix corruption after error in update_refcountblock/qcow2-refcount.c+4 -01 reply

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchStefan Hajnoczi
1/5R-b
2/5R-b
3/5R-b
4/5
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/5] qcow2 fixes

Another series of fixes for bugs that were found using blkdebug. The last two of them are presumably relevant even outside error paths and can cause corruption. They should be applied to stable-0.12, too.

Kevin Wolf (5):
qcow2: Allow qcow2_get_cluster_offset to return errors
qcow2: Change l2_load to return 0/-errno
qcow2: Return right error code in write_refcount_block_entries
qcow2: Fix corruption after refblock allocation
qcow2: Fix corruption after error in update_refcount

 block/qcow2-cluster.c  |   70 ++++++++++++++++++++++++++++-------------------
 block/qcow2-refcount.c |   42 +++++++++++++++++++---------
 block/qcow2.c          |   16 +++++++++--
 block/qcow2.h          |    4 +-
 4 files changed, 85 insertions(+), 47 deletions(-)