Skip to content

More block-related fixes and cleanups

Markus Armbruster qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 31 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12scsi: scsi_bus_legacy_handle_cmdline() can fail, fix callershw/esp.c hw/lsi53c895a.c hw/pci-hotplug.c +3 more+16 -81 reply
2/12ide: Make it explicit that ide_create_drive() can't failhw/ide/qdev.c+1 -21 reply
3/12blockdev: Remove drive_get_serial()blockdev.c blockdev.h+0 -131 reply
4/12blockdev: New drive_of_blockdev()blockdev.c blockdev.h+13 -07 replies
5/12blockdev: Clean up automatic drive deletionblockdev.c blockdev.h hw/qdev-properties.c +4 more+56 -71 reply
6/12qdev: Decouple qdev_prop_drive from DriveInfoblock_int.h hw/fdc.c hw/ide/core.c +13 more+73 -721 reply
7/12blockdev: drive_get_by_id() is no longer used, removeblockdev.c blockdev.h+0 -131 reply
8/12block: Catch attempt to attach multiple devices to a blockdevblock.c block.h block_int.h +8 more+70 -1513 replies
9/12savevm: Survive hot-unplug of snapshot deviceblock.c block.h savevm.c+30 -274 replies
10/12block: Fix virtual media change for if=noneblock.c block.h hw/fdc.c +4 more+24 -31 reply
11/12ide: Make PIIX and ISA IDE init functions return the qdevhw/ide.h hw/ide/isa.c hw/ide/piix.c+14 -111 reply
12/12pc: Fix CMOS info for drives defined with -devicehw/ide.h hw/ide/qdev.c hw/pc.c +2 more+81 -410 replies

Reviews trailers per patch

9 of 12 patches have a Reviewed-by or Acked-by.

PatchChristoph Hellwig
1/12R-b
2/12R-b
3/12R-b
4/12
5/12R-b
6/12R-b
7/12R-b
8/12
9/12R-b
10/12R-b
11/12R-b
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 00/12] More block-related fixes and cleanups

I'm working on cleanly separating block device host and guest parts. I'd like to route all this work through Kevin's block tree. This is still just preliminaries.

There will be at least one more round of cleanup & fixes before blockdev_add proper. I intend to start with a minimal QMP-only version, then add features.

Markus Armbruster (12):
scsi: scsi_bus_legacy_handle_cmdline() can fail, fix callers
ide: Make it explicit that ide_create_drive() can't fail
blockdev: Remove drive_get_serial()
blockdev: New drive_of_blockdev()
blockdev: Clean up automatic drive deletion
qdev: Decouple qdev_prop_drive from DriveInfo
blockdev: drive_get_by_id() is no longer used, remove
block: Catch attempt to attach multiple devices to a blockdev
savevm: Survive hot-unplug of snapshot device
block: Fix virtual media change for if=none
ide: Make PIIX and ISA IDE init functions return the qdev
pc: Fix CMOS info for drives defined with -device

 block.c              |   55 +++++++++++++++++++++++++++++
 block.h              |    5 +++
 block_int.h          |    8 ++--
 blockdev.c           |   45 +++++++++++++++---------
 blockdev.h           |    7 +++-
 hw/esp.c             |    3 +-
 hw/fdc.c             |   32 +++++++++-------
 hw/ide.h             |   13 ++++---
 hw/ide/core.c        |   18 +++++----
 hw/ide/internal.h    |    2 +-
 hw/ide/isa.c         |    8 ++--
 hw/ide/piix.c        |    6 ++-
 hw/ide/qdev.c        |   22 ++++++++---
 hw/lsi53c895a.c      |    2 +-
 hw/pc.c              |   94 +++++++++++++++++++++++++++++++------------------
 hw/pc.h              |    3 +-
 hw/pc_piix.c         |   16 ++++++---
 hw/pci-hotplug.c     |   10 ++++-
 hw/qdev-properties.c |   46 +++++++++++++++++++++----
 hw/qdev.h            |    7 ++--
 hw/s390-virtio.c     |    2 +-
 hw/scsi-bus.c        |   19 ++++++----
 hw/scsi-disk.c       |   21 ++++++-----
 hw/scsi-generic.c    |    7 ++--
 hw/scsi.h            |    4 +-
 hw/usb-msd.c         |   29 ++++++++++++---
 hw/virtio-blk.c      |    3 +-
 hw/virtio-pci.c      |    4 +-
 savevm.c             |   31 ++--------------
 29 files changed, 344 insertions(+), 178 deletions(-)