Skip to content

blkdebug: Fix config with multiple states

Kevin Wolf qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 1 replyIn review
  2. v13 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- Use Markus' qemu_opts_reset for freeing QemuOpts. Makes the code reusable and fixes a use-after-free bug.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4qemu-option: New qemu_opts_reset()qemu-option.c qemu-option.h+10 -00 replies
2/4blkdebug: Fix set_state_opts definitionblock/blkdebug.c+1 -10 replies
3/4blkdebug: Free QemuOpts after having read the configblock/blkdebug.c+2 -00 replies
4/4blkdebug: Initialize state as 1block/blkdebug.c+3 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/4] blkdebug: Fix config with multiple states

Turns out that using more than one state doesn't really work well. I'm trying to reproduce a bug for which I need states, so now is the time to fix it.

v2:
- Use Markus' qemu_opts_reset for freeing QemuOpts. Makes the code reusable and fixes a use-after-free bug.

Kevin Wolf (3):
blkdebug: Fix set_state_opts definition
blkdebug: Free QemuOpts after having read the config
blkdebug: Initialize state as 1

Markus Armbruster (1):
qemu-option: New qemu_opts_reset()

 block/blkdebug.c |    7 ++++++-
 qemu-option.c    |    9 +++++++++
 qemu-option.h    |    1 +
 3 files changed, 16 insertions(+), 1 deletions(-)