Skip to content

libertas: finish conversion to direct command architecture

Dan Williams linux-wireless 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest16 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16libertas: clean up MONITOR_MODE commanddrivers/net/wireless/libertas/cfg.c drivers/net/wireless/libertas/cmd.c drivers/net/wireless/libertas/cmd.h +1 more+33 -720 replies
2/16libertas: clean up RSSI commanddrivers/net/wireless/libertas/cfg.c drivers/net/wireless/libertas/cfg.h drivers/net/wireless/libertas/cmd.c +5 more+51 -770 replies
3/16libertas: convert 11D_DOMAIN_INFO to a direct commanddrivers/net/wireless/libertas/cfg.c drivers/net/wireless/libertas/cmd.c drivers/net/wireless/libertas/cmd.h +4 more+139 -2380 replies
4/16libertas: remove unused indirect TPC_CFG command leftoversdrivers/net/wireless/libertas/cmd.c drivers/net/wireless/libertas/cmdresp.c drivers/net/wireless/libertas/host.h+0 -200 replies
5/16libertas: remove unused Automatic Frequency Control commanddrivers/net/wireless/libertas/cmd.c drivers/net/wireless/libertas/cmdresp.c drivers/net/wireless/libertas/host.h+3 -230 replies
6/16libertas: remove Beacon Controldrivers/net/wireless/libertas/cfg.h drivers/net/wireless/libertas/cmd.c drivers/net/wireless/libertas/cmdresp.c +1 more+2 -110 replies
7/16libertas: convert LED_GPIO_CTRL to a direct commanddrivers/net/wireless/libertas/host.h+2 -30 replies
8/16libertas: convert register access to direct commandsdrivers/net/wireless/libertas/cmd.c drivers/net/wireless/libertas/cmd.h drivers/net/wireless/libertas/cmdresp.c +3 more+94 -1800 replies
9/16libertas: convert Mesh Blinding Table access to a direct commanddrivers/net/wireless/libertas/cmd.c drivers/net/wireless/libertas/cmdresp.c drivers/net/wireless/libertas/host.h +2 more+158 -460 replies
10/16libertas: convert CMD_FWT_ACCESS to a direct commanddrivers/net/wireless/libertas/cmd.c drivers/net/wireless/libertas/cmdresp.c drivers/net/wireless/libertas/host.h +2 more+26 -340 replies
11/16libertas: remove unused indirect command response handlerdrivers/net/wireless/libertas/cmdresp.c+1 -240 replies
12/16libertas: convert PS_MODE to a direct commanddrivers/net/wireless/libertas/cmd.c drivers/net/wireless/libertas/cmd.h drivers/net/wireless/libertas/cmdresp.c +4 more+95 -1260 replies
13/16libertas: convert DEEP_SLEEP timer to a direct commanddrivers/net/wireless/libertas/cmd.c drivers/net/wireless/libertas/main.c+8 -120 replies
14/16libertas: kill unused lbs_prepare_and_send_command()drivers/net/wireless/libertas/cmd.c drivers/net/wireless/libertas/cmd.h drivers/net/wireless/libertas/cmdresp.c +1 more+9 -1460 replies
15/16libertas: rename lbs_get_cmd_ctrl_node() to lbs_get_free_cmd_node()drivers/net/wireless/libertas/cmd.c+2 -40 replies
16/16libertas: remove unused cmd_pending waitqdrivers/net/wireless/libertas/dev.h drivers/net/wireless/libertas/main.c+0 -90 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [wt PATCH 0/16] libertas: finish conversion to direct command architecture

This series finishes conversion of all firmware commands to direct commands instead of using the indirect (and I'd argue less clear) model that the original vendor driver used. This was the last barrier to scale before we can begin cleaning up the command submission structure to be less convoluted and more reliable. It's a net code loss too which makes many kittens and puppies happy.

Please apply to wireless-testing. Note that wireless-testing is somewhat broken as a result of the cfg80211 patches, but this series should make that easier to fix up.

Dan Williams (16):
libertas: clean up MONITOR_MODE command
libertas: clean up RSSI command
libertas: convert 11D_DOMAIN_INFO to a direct command
libertas: remove unused indirect TPC_CFG command leftovers
libertas: remove unused Automatic Frequency Control command
libertas: remove Beacon Control
libertas: convert LED_GPIO_CTRL to a direct command
libertas: convert register access to direct commands
libertas: convert Mesh Blinding Table access to a direct command
libertas: convert CMD_FWT_ACCESS to a direct command
libertas: remove unused indirect command response handler
libertas: convert PS_MODE to a direct command
libertas: convert DEEP_SLEEP timer to a direct command
libertas: kill unused lbs_prepare_and_send_command()
libertas: rename lbs_get_cmd_ctrl_node() to lbs_get_free_cmd_node()
libertas: remove unused cmd_pending waitq

 drivers/net/wireless/libertas/cfg.c     |  197 +--------
 drivers/net/wireless/libertas/cfg.h     |    6 -
 drivers/net/wireless/libertas/cmd.c     |  718 +++++++++++++------------------
 drivers/net/wireless/libertas/cmd.h     |   25 +-
 drivers/net/wireless/libertas/cmdresp.c |  179 +--------
 drivers/net/wireless/libertas/debugfs.c |   67 +---
 drivers/net/wireless/libertas/decl.h    |    5 -
 drivers/net/wireless/libertas/defs.h    |   18 -
 drivers/net/wireless/libertas/dev.h     |    6 -
 drivers/net/wireless/libertas/host.h    |  142 +++----
 drivers/net/wireless/libertas/if_usb.c  |    4 +-
 drivers/net/wireless/libertas/main.c    |   33 +-
 drivers/net/wireless/libertas/mesh.c    |  216 ++++++++--
 drivers/net/wireless/libertas/mesh.h    |   14 +-
 14 files changed, 613 insertions(+), 1017 deletions(-)