Skip to content

Turn on the -Wextra compile flag (Take 2)

Steve Dickson linux-nfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest24 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/24Enable extra compile warnings (-Wextra) by default.configure.ac+1 -10 replies
2/24Removed warnings from rpcdispatch.csupport/nfs/rpcdispatch.c+2 -20 replies
3/24Remove warnings from svc_socket.csupport/include/nfslib.h support/nfs/rpcmisc.c support/nfs/svc_socket.c+5 -50 replies
4/24emove warnings from cacheio.csupport/nfs/cacheio.c+1 -10 replies
5/24Remove warnings from nfs_mntent.csupport/nfs/nfs_mntent.c+1 -10 replies
6/24Removed warnings from conffile.csupport/nfs/conffile.c+4 -40 replies
7/24Removed warnings from fsloc.cutils/mountd/cache.c utils/mountd/fsloc.c utils/mountd/fsloc.h+3 -30 replies
8/24Removed warnings from cache.csupport/include/nfslib.h utils/mountd/cache.c+10 -100 replies
9/24Removed warnings from nfssvc.cutils/nfsd/nfssvc.c+3 -30 replies
10/24Removed warnings from nfsstat.cutils/nfsstat/nfsstat.c+3 -30 replies
11/24Removed warnings from atomicio.cutils/idmapd/atomicio.c+2 -10 replies
12/24Removed warnings from gssd.cutils/gssd/gssd.c+1 -10 replies
13/24Removed warnings from gssd_main_loop.cutils/gssd/gssd_main_loop.c+2 -00 replies
14/24Removed warnings from krb5_util.cutils/gssd/gssd_proc.c utils/gssd/krb5_util.c utils/gssd/krb5_util.h+23 -100 replies
15/24Removed warnings from gssd_proc.cutils/gssd/gssd_proc.c+3 -30 replies
16/24Removed warnings from svcgssd.cutils/gssd/svcgssd.c+1 -10 replies
17/24Removed warnings from nfsmount.cutils/mount/nfsmount.c+6 -20 replies
18/24Removed warnings from nfs4mount.cutils/mount/nfs4mount.c+1 -10 replies
19/24Removed warnings from network.csupport/include/nfslib.h utils/mount/network.c+5 -10 replies
20/24Removed warnings from svcgssd_proc.cutils/gssd/svcgssd_proc.c+3 -90 replies
21/24Removed warnings from configfile.cutils/mount/configfile.c+4 -20 replies
22/24Removed warnings from idmapd.cutils/idmapd/idmapd.c+26 -100 replies
23/24Removed warnings from mountd.cutils/mountd/mountd.c+8 -60 replies
24/24Remove warnings from nfsctl.csupport/export/nfsctl.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/24] Turn on the -Wextra compile flag (Take 2)

To catch potential during compile time, the -Wextra compile flag was added to the CFLAGS. The raise the bar like this, with regard to warnings, will keep the code cleaner in the long run.

Steve Dickson (24):
Enable extra compile warnings (-Wextra) by default. Removed warnings from rpcdispatch.c
Remove warnings from svc_socket.c
emove warnings from cacheio.c
Remove warnings from nfs_mntent.c
Removed warnings from conffile.c
Removed warnings from fsloc.c
Removed warnings from cache.c
Removed warnings from nfssvc.c
Removed warnings from nfsstat.c
Removed warnings from atomicio.c
Removed warnings from gssd.c
Removed warnings from gssd_main_loop.c Removed warnings from krb5_util.c
Removed warnings from gssd_proc.c
Removed warnings from svcgssd.c
Removed warnings from nfsmount.c
Removed warnings from nfs4mount.c
Removed warnings from network.c
Removed warnings from svcgssd_proc.c Removed warnings from configfile.c
Removed warnings from idmapd.c
Removed warnings from mountd.c
Remove warnings from nfsctl.c

 configure.ac                |    2 +-
 support/export/nfsctl.c     |    2 +-
 support/include/nfslib.h    |    7 +++++--
 support/nfs/cacheio.c       |    2 +-
 support/nfs/conffile.c      |    8 ++++----
 support/nfs/nfs_mntent.c    |    2 +-
 support/nfs/rpcdispatch.c   |    4 ++--
 support/nfs/rpcmisc.c       |    2 +-
 support/nfs/svc_socket.c    |    6 +++---
 utils/gssd/gssd.c           |    2 +-
 utils/gssd/gssd_main_loop.c |    2 ++
 utils/gssd/gssd_proc.c      |    8 ++++----
 utils/gssd/krb5_util.c      |   29 +++++++++++++++++++++--------
 utils/gssd/krb5_util.h      |    2 +-
 utils/gssd/svcgssd.c        |    2 +-
 utils/gssd/svcgssd_proc.c   |   12 +++---------
 utils/idmapd/atomicio.c     |    3 ++-
 utils/idmapd/idmapd.c       |   36 ++++++++++++++++++++++++++----------
 utils/mount/configfile.c    |    6 ++++--
 utils/mount/network.c       |    3 ++-
 utils/mount/nfs4mount.c     |    2 +-
 utils/mount/nfsmount.c      |    8 ++++++--
 utils/mountd/cache.c        |   20 ++++++++++----------
 utils/mountd/fsloc.c        |    2 +-
 utils/mountd/fsloc.h        |    2 +-
 utils/mountd/mountd.c       |   14 ++++++++------
 utils/nfsd/nfssvc.c         |    6 +++---
 utils/nfsstat/nfsstat.c     |    6 +++---
 28 files changed, 119 insertions(+), 81 deletions(-)
Signature · 1 line
1.7.2