Skip to content

icon support patches

Kristen Carlson Accardi ofono 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/26 patches 6 repliesIn review
  2. v2 posting 1/26 patches 1 replySuperseded
  3. v17 patches 0 repliesSuperseded

Patches in v2 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6simutil: add fileid for EFimgsrc/simutil.h+1 -01 reply
2/6stkutil: change uint32_t to guint32src/stkutil.h+1 -11 reply
3/6sim: read EFimgsrc/sim.c+49 -05 replies
4/6sim: read EFiidfsrc/sim.c+198 -33 replies
5/6sim: implement GetIconsrc/sim.c+216 -00 replies
6/6test: add get-icon scripttest/get-icon+25 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/6] icon support patches

Changes from last version:

* bugfix in patch 3, read EFimg, sim_efimg_read_cb. Don't calculate num_records without first checking for ok

* bugfix in patch 5, implement GetIcon, ofono_sim_get_image When calling back with error, use 0 as error code, not -1

Kristen Carlson Accardi (6):
simutil: add fileid for EFimg
stkutil: change uint32_t to guint32
sim: read EFimg
sim: read EFiidf
sim: implement GetIcon
test: add get-icon script

 src/sim.c     |  466 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
 src/simutil.h |    1 +
 src/stkutil.h |    2 +-
 test/get-icon |   25 +++
 4 files changed, 490 insertions(+), 4 deletions(-)
 create mode 100755 test/get-icon
Signature · 1 line
1.7.2.1