Code clean-up - removing "dead" code.
Get series with b4
b4 am [email protected]...Versions newest first
- v1 Latest3 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | Clean-up: Remove pthread and mutex locking codeMakefile.am acinclude.m4 buffer.c +29 more | +1 | 0 replies | |
| 2/3 | Clean-up: Remove more dead and inactive code pathsbuffer.c forward.c mbuf.c +8 more | +5 | 0 replies | |
| 3/3 | Clean-up: Removing useless code - hash related functionslist.c list.h mtcp.c +3 more | +20 | 0 replies |
Reviews trailers per patch
None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | James Yonan |
|---|---|
| Series | A-b A-b A-b |
| 1/3 | |
| 2/3 | |
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Openvpn-devel] [PATCH 0/3] Code clean-up - removing "dead" code.
This is a patch series which tries to do some source code clean-up. After having noticed that ./configure --enable-pthread was simply doing *nothing*, as it was forcefully being disabled in syshead.h, I went through the code and began cleaning up this and some of the related code.
As threading is not buildable in the current code base and OpenVPN 3.x most likely will have a brand new design in regards to the threading, it seemed to be better to clean up this code. This is also to remove false presumptions that OpenVPN supports threads.
kind regards,
David Sommerseth
*** BLURB HERE ***
David Sommerseth (3):
Clean-up: Remove pthread and mutex locking code
Clean-up: Remove more dead and inactive code paths
Clean-up: Removing useless code - hash related functions
Makefile.am | 1 - acinclude.m4 | 224 ----------------------------------------------------- buffer.c | 5 - buffer.h | 1 - config-win32.h | 5 - configure.ac | 38 +--------- crypto.c | 3 - error.c | 39 --------- error.h | 17 ---- forward.c | 10 --- init.c | 50 ------------ list.c | 24 +----- list.h | 33 +------- mbuf.c | 16 +---- mbuf.h | 3 +- misc.c | 23 ------ mroute.c | 6 -- mroute.h | 13 --- mtcp.c | 5 +- mudp.c | 3 - multi.c | 32 +++----- multi.h | 2 - openvpn.h | 3 - options.c | 36 --------- options.h | 5 - otime.c | 2 - otime.h | 1 - perf.c | 4 - pf.c | 2 +- plugin.c | 4 - pool.h | 1 - schedule.c | 4 - schedule.h | 8 -- socket.c | 7 -- ssl.c | 5 - ssl.h | 4 - syshead.h | 18 ---- thread.c | 156 ------------------------------------- thread.h | 235 -------------------------------------------------------- 39 files changed, 26 insertions(+), 1022 deletions(-) delete mode 100644 thread.c delete mode 100644 thread.h
Signature · 1 line
1.7.2.2