Skip to content

OMAP_VOUT: Allow omap_vout to build without VRFB

Archit Taneja linux-media linux-omap 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 2 repliesIn review
  2. v33 patches 4 repliesSuperseded
  3. v22 patches 4 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches4 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2OMAP_VOUT: CLEANUP: Move some functions and macros from omap_voutdrivers/media/video/omap/omap_vout.c drivers/media/video/omap/omap_voutdef.h drivers/media/video/omap/omap_voutlib.c +1 more+108 -1091 reply
2/2OMAP_VOUT: Create separate file for VRFB related API'sdrivers/media/video/omap/Kconfig drivers/media/video/omap/Makefile drivers/media/video/omap/omap_vout.c +3 more+533 -3751 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchVaibhav Hiremath
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/2] OMAP_VOUT: Allow omap_vout to build without VRFB

Introduce omap_vout_vrfb.c and omap_vout_vrfb.h, for all VRFB related API's, making OMAP_VOUT driver independent from VRFB. This is required for OMAP4 DSS, since OMAP4 doesn't have VRFB block.

A new enum called vout_rotation_type is introduced to differentiate between no rotation and vrfb rotation. A member rotation_type is introduced in omapvideo_info, this allows to call vrfb specific functions only if the rotation type is VOUT_ROT_VRFB When the rotation_type is set to VOUT_ROT_NONE, the S_CTRL ioctl prevents the user setting a non zero rotation or non zero mirror value.

Archit Taneja (2):
OMAP_VOUT: CLEANUP: Move some functions and macros from omap_vout
OMAP_VOUT: Create separate file for VRFB related API's

 drivers/media/video/omap/Kconfig          |    2 +-
 drivers/media/video/omap/Makefile         |    1 +
 drivers/media/video/omap/omap_vout.c      |  566 +++++------------------------
 drivers/media/video/omap/omap_vout_vrfb.c |  390 ++++++++++++++++++++
 drivers/media/video/omap/omap_vout_vrfb.h |   40 ++
 drivers/media/video/omap/omap_voutdef.h   |   78 ++++
 drivers/media/video/omap/omap_voutlib.c   |   44 +++
 drivers/media/video/omap/omap_voutlib.h   |    2 +
 8 files changed, 640 insertions(+), 483 deletions(-)
 create mode 100644 drivers/media/video/omap/omap_vout_vrfb.c
 create mode 100644 drivers/media/video/omap/omap_vout_vrfb.h

--
Version 4:
- Some minor fixes, renaming of git commits, patches 2 and 3 merged into 1.
Version 3:
- Introduce a new enum at V4L2 driver level which cleanly differentiates between vrfb rotation and no rotation, incorporate comments given for v2
Version 2:
- Don't try to enable SDRAM rotation , return an error if non zero rotation is attempted when rotation_type is set to SDMA rotation.
Version 1:
http://www.mail-archive.com/[email protected]/msg21937.html