Skip to content

RFC Replace buffer cache hash with rbtrees

Dave Chinner linux-xfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest4 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4xfs: kill XBF_FS_MANAGED buffersfs/xfs/linux-2.6/xfs_buf.c fs/xfs/linux-2.6/xfs_buf.h fs/xfs/xfs_mount.c+35 -433 replies
2/4xfs: use unhashed buffers for size checksfs/xfs/linux-2.6/xfs_buf.c fs/xfs/linux-2.6/xfs_buf.h fs/xfs/xfs_fsops.c +2 more+79 -663 replies
3/4xfs: remove buftarg hash for external devicesfs/xfs/linux-2.6/xfs_buf.c+5 -11 reply
4/4xfs: convert buffer cache hash to rbtreefs/xfs/linux-2.6/xfs_buf.c fs/xfs/linux-2.6/xfs_buf.h fs/xfs/linux-2.6/xfs_super.c +2 more+86 -795 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchChristoph Hellwig
1/4
2/4
3/4R-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC] [PATCH 0/4] Replace buffer cache hash with rbtrees

This patch series cleans up several unconventional buffer uses to avoid using cached buffers, and then converts the buffer cache indexing to use a set of per-ag rbtrees rather than a hash. This version show no performance degradation on my 1.1TB filesystem under parallel create and unlink compared to the existing enlarged hash cache. In both cases _xfs_buf_find() is consuming 5-6% of the entire CPU time of the workload.

This patchset is needed to prepare for moving away from using the page cache as the backing cache and instead maintaining a LRU of cached buffers. This is necessary because on larger filesystems we are completely unable to maintain the working set of metadata buffers hot in cache as we cannot control page cache reclaim. It means that we need to be able to hold a lot more buffers in memory than we currently do and as such the hash based indexing needs replacing first.

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs